Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't trigger needless_late_init when the first usage is in macro #14053

Merged
merged 1 commit into from
Jan 22, 2025
Merged

don't trigger needless_late_init when the first usage is in macro #14053

merged 1 commit into from
Jan 22, 2025
+26 −0

Conversation

lapla-cogito
Copy link
Contributor

fix #13776

changelog: [needless_late_init]: don't trigger needless_late_init when the first usage is in macro

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 21, 2025
y21
y21 reviewed Jan 22, 2025
View reviewed changes
tests/ui/needless_late_init.rs Outdated Show resolved Hide resolved
clippy_lints/src/needless_late_init.rs Outdated Show resolved Hide resolved
@lapla-cogito lapla-cogito force-pushed the issue_13776 branch 2 times, most recently from b72aef5 to c05e656 Compare January 22, 2025 01:41
@lapla-cogito lapla-cogito requested a review from y21 January 22, 2025 01:44
y21
y21 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, looks good

@y21 y21 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into rust-lang:master with commit 396de57 Jan 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[needless_late_init] suggestion doesn't compile when the initializing takes place inside macro
3 participants
@lapla-cogito @rustbot @y21