Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new manual_option_as_slice lint #13901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

new manual_option_as_slice lint #13901

wants to merge 1 commit into from
+432 −9

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Dec 29, 2024 •
edited by blyxyas
Loading

Hey folks. It's been a while since I added the as_slice method to Option, and I totally forgot about a lint to suggest it. Well, I had some time around Christmas, so here it is now.

changelog: add [manual_option_as_slice] lint

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2024
@llogiq llogiq force-pushed the manual-option-as-slice branch 2 times, most recently from b3fb332 to 44b74b4 Compare December 29, 2024 19:09
@llogiq
Copy link
Contributor Author

llogiq commented Dec 30, 2024

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned xFrednet Dec 30, 2024
@llogiq llogiq force-pushed the manual-option-as-slice branch 2 times, most recently from a037517 to 733cde9 Compare January 16, 2025 06:17
blyxyas
blyxyas requested changes Jan 20, 2025
View reviewed changes
clippy_lints/src/manual_option_as_slice.rs Show resolved Hide resolved
tests/ui/manual_option_as_slice.fixed Outdated Show resolved Hide resolved
tests/ui/manual_option_as_slice.rs Show resolved Hide resolved
clippy_lints/src/manual_option_as_slice.rs Outdated Show resolved Hide resolved
clippy_lints/src/manual_option_as_slice.rs Outdated Show resolved Hide resolved
clippy_lints/src/manual_option_as_slice.rs Show resolved Hide resolved
@llogiq llogiq force-pushed the manual-option-as-slice branch 2 times, most recently from 98326c0 to 0ed4623 Compare January 22, 2025 11:56
@llogiq llogiq requested a review from blyxyas January 22, 2025 11:56
@llogiq llogiq force-pushed the manual-option-as-slice branch 3 times, most recently from b8e8b12 to c548460 Compare January 22, 2025 19:15
blyxyas
blyxyas approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ I'll open an FCP

@llogiq llogiq force-pushed the manual-option-as-slice branch from c548460 to 33256d8 Compare January 26, 2025 13:46
@llogiq llogiq force-pushed the manual-option-as-slice branch from 33256d8 to 13be95a Compare January 26, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo left review comments

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@llogiq @rustbot @Alexendoo @blyxyas @xFrednet