Move format_push_string and format_collect to pedantic
#13894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
cc: @y21 |
Centri3
approved these changes
Jan 6, 2025
| @@ -35,7 +35,7 @@ declare_clippy_lint! { | |||
| /// ``` | |||
| #[clippy::version = "1.62.0"] | |||
| pub FORMAT_PUSH_STRING, | |||
| restriction, | |||
| pedantic, | |||
There was a problem hiding this comment.
Please make sure to change "Why restrict this" to "Why is this bad".
| @@ -255,6 +255,7 @@ fn get_lint_file_contents(lint: &LintData<'_>, enable_msrv: bool) -> String { | |||
| let name_camel = to_camel_case(lint.name); | |||
| let name_upper = lint_name.to_uppercase(); | |||
|
|
|||
| #[expect(clippy::format_push_string)] | |||
There was a problem hiding this comment.
Why can't you use writedoc! here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11434 by moving
format_push_stringandformat_collectto pedantic.changelog: Move
format_push_stringandformat_collectto pedantic