Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust version #418

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Update rust version #418

merged 1 commit into from
Apr 30, 2024

Conversation

calebzulawski
Copy link
Member

No description provided.

@calebzulawski calebzulawski changed the title Lock rust version Update rust version Apr 30, 2024
@calebzulawski
Copy link
Member Author

Whoops, we already had the toolchain locked. Thought I hadn't done it yet. Why did we suddenly get the inline_const stabilization errors? Maybe something wrong in the CI script

@programmerjake
Copy link
Member

Whoops, we already had the toolchain locked. Thought I hadn't done it yet. Why did we suddenly get the inline_const stabilization errors? Maybe something wrong in the CI script

because inline consts were stabilized on nightly: rust-lang/rust#104087 (comment)

@programmerjake programmerjake merged commit 7cd6f95 into master Apr 30, 2024
65 of 67 checks passed
@calebzulawski
Copy link
Member Author

I meant why was I seeing them when we were supposed to be locked to an older toolchain

@programmerjake
Copy link
Member

I meant why was I seeing them when we were supposed to be locked to an older toolchain

the updated version uses today's (or yesterday depending on time zones) nightly...I wouldn't call that old. the stabilization PR was merged about a week ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmerjake programmerjake Awaiting requested review from programmerjake

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebzulawski @programmerjake