Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document PartialOrd difference to simd_min and simd_max #413

Merged
merged 2 commits into from
Apr 10, 2024
Merged

document PartialOrd difference to simd_min and simd_max #413

merged 2 commits into from
Apr 10, 2024

Conversation

KonradHoeffner
Copy link
Contributor

@KonradHoeffner KonradHoeffner commented Apr 10, 2024

Avoids a migration pitfall from packed_simd as described in #402.
This adds a single line of documentation, no code change.

Fixes: #402

Avoid migration pitfall from packed_simd as described in #402.
@programmerjake
Copy link
Member

can you add it for Ord too?

@KonradHoeffner
Copy link
Contributor Author

@programmerjake Good point! Added the comment for Ord as well.

@calebzulawski calebzulawski merged commit 979a495 into rust-lang:master Apr 10, 2024
5 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migration pitfall from packed_simd: PartialOrd behaves differently?
3 participants