Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run the 4-lane tests in Miri #412

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 9, 2024

This should cut down the CI times for the Miri job.

Also only test one non-power-of-2 configuration (if/when that ever gets enabled) in Miri, again to avoid the tests taking too long. I don't see why odd vs even non-power-of-2 would make a big difference for Miri.

@RalfJung RalfJung changed the title do not run thr 4-lane tests in Miri do not run the 4-lane tests in Miri Apr 9, 2024
@programmerjake
Copy link
Member

programmerjake commented Apr 9, 2024

I don't see why odd vs even non-power-of-2 would make a big difference for Miri.

oh, that's because of alignment -- the layout I proposed would have align 1 for Simd<u8, 5> but align 2 for Simd<u8, 6>, since basically it picks the biggest alignment that doesn't require padding.

so, it won't make any difference now, but later assuming we use the proposed layout, it will make a difference since Miri can (hopefully) catch misaligned accesses.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 9, 2024 via email

@calebzulawski calebzulawski merged commit d5dfa72 into rust-lang:master Apr 11, 2024
5 of 67 checks passed
@RalfJung RalfJung deleted the miri-lanes branch April 11, 2024 05:28
@RalfJung
Copy link
Member Author

With this, Miri takes 27min. The second-slowest job seems to be "default on aarch64-unknown-linux-gnu" which takes 19min.

The only way I see to further reduce CI times is to only test the 2-lane tests in Miri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants