Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on big endian aarch64 #396

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 22, 2024

Since nightly-2024-02-06 which includes rust-lang/stdarch#1485, the build of core_simd on big endian aarch64 is broken.

$ cargo build --target aarch64_be-unknown-linux-gnu -Z build-std
error[E0432]: unresolved import `super::neon`
  --> /Users/taiki/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/../../portable-simd/crates/core_simd/src/vendor/arm.rs:74:16
   |
74 |     use super::neon::*;
   |                ^^^^ could not find `neon` in `super`

error[E0412]: cannot find type `float64x1_t` in this scope
  --> /Users/taiki/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/../../portable-simd/crates/core_simd/src/vendor/arm.rs:77:46
   |
77 |     from_transmute! { unsafe Simd<f64, 1> => float64x1_t }
   |                                              ^^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `float64x2_t` in this scope
  --> /Users/taiki/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/../../portable-simd/crates/core_simd/src/vendor/arm.rs:78:39
   |
78 |     from_transmute! { unsafe f64x2 => float64x2_t }
   |                                       ^^^^^^^^^^^ not found in this scope

(The changes made in https://github.com/rust-lang/rust/pull/117372/files#diff-1d0639f80e64822373516a52eb408dc844e246110aaf75fe421e07388b9dee18 were sufficient for arm but not for aarch64.)

FYI @Amanieu

@taiki-e
Copy link
Member Author

taiki-e commented Feb 22, 2024

CI failures should be fixed in #397.

taiki-e added a commit to taiki-e/rust-cross-toolchain that referenced this pull request Feb 22, 2024
taiki-e added a commit to taiki-e/setup-cross-toolchain-action that referenced this pull request Feb 22, 2024
taiki-e added a commit to taiki-e/atomic-maybe-uninit that referenced this pull request Feb 22, 2024
taiki-e added a commit to taiki-e/portable-atomic that referenced this pull request Feb 22, 2024
taiki-e added a commit to taiki-e/portable-atomic that referenced this pull request Feb 22, 2024
@calebzulawski calebzulawski merged commit 94f4f68 into rust-lang:master Feb 22, 2024
66 checks passed
@calebzulawski
Copy link
Member

Thanks! Does this warrant a subtree update?

@taiki-e taiki-e deleted the aarch64-big branch August 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants