Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feature flags #389

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 9, 2024

const_intrinsic_copy stabilization got reverted in rust-lang/rust#117905.

@RalfJung RalfJung changed the title re-add const_intrinsic_copy feature fix feature flags Feb 9, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Feb 9, 2024

Okay this is painful, we'll need a bunch of careful #[cfg] in the lib.rs that enables exactly the stdarch features needed for each configuration. Enabling features that don't exist for the current target just shows "unknown feature" errors...

Copy link
Member

@programmerjake programmerjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it compiles everywhere, lgtm!

@calebzulawski calebzulawski merged commit f505736 into rust-lang:master Feb 9, 2024
66 checks passed
@calebzulawski
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants