-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ci from travis to github actions #352
Port ci from travis to github actions #352
Conversation
The last run of the actions can also be seen in my fork: https://github.com/jhorstmann/packed_simd/actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this looks great! Thank you!
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Oof, this has some errors on master, judging by https://github.com/rust-lang/packed_simd/actions/runs/5673019417 |
#355 gets us half of the way there. |
This sets up github actions workflows that should run the same tests as were previously setup for travis ci. Luckily none of the shell scripts needed changing, only a new set of yaml files.
There are a few FIXME issues, where I could use some help or which could maybe be solved in followup:
simd_shuffle
#350dox.sh
that I haven't looked into yetispc
feature for the benchmarks is currently disabled, because I haven't found an easy way to add the binary to thePATH
There is a mostly unrelated change in the instruction verification tests for vector rotates, that turned out to be a red herring. The verify tests for i586 and i686 were failing because the verifier did not expect a call instruction in the code. That call instruction however was only needed to support relocations, the code was getting inlined correctly. However, I think the target features are more correct after the change, the 128bit type m64x2 should require avx512vl, the other two tests use 512bit vectors where avx512f should suffice.