Fix up kv feature activation #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
changed the title
Thomasdezeeuw
approved these changes
Jan 10, 2025
| @@ -44,7 +44,7 @@ release_max_level_info = [] | |||
| release_max_level_debug = [] | |||
| release_max_level_trace = [] | |||
|
|
|||
| std = [] | |||
| std = ["value-bag?/std"] | |||
There was a problem hiding this comment.
Is this supported in Rust 1.60 (our MSRV)?
There was a problem hiding this comment.
https://doc.rust-lang.org/cargo/reference/features.html
According to the doc linked, it's available starting from 1.60 so it should be fine.
tisonkun
approved these changes
Jan 10, 2025
| @@ -44,7 +44,7 @@ release_max_level_info = [] | |||
| release_max_level_debug = [] | |||
| release_max_level_trace = [] | |||
|
|
|||
| std = [] | |||
| std = ["value-bag?/std"] | |||
There was a problem hiding this comment.
https://doc.rust-lang.org/cargo/reference/features.html
According to the doc linked, it's available starting from 1.60 so it should be fine.
|
@tisonkun No problems! It's our fault for not catching it in CI. I've been meaning to add |
This was referenced Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #658
Looks like a feature combination broke in
0.4.23, so I've addedcargo hackto our CI to make sure we test all possible combinations.