Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relibm crate #237

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

augustin-cheron
Copy link

Add a crate to build a c ABI compatible libm in order to test it against other libm test suite.
This crate currently support libc-test use in musl and openlibm tests and benchmark.

@tgross35
Copy link
Contributor

tgross35 commented Jan 7, 2025

Hey! Sorry this hasn't been looked at in a while. If you are still interested in adding this functionality I think we could do this, but it doesn't need to be a separate crate. Instead, just add a src/no_mangle.rs file that wraps each function in a #[no_mangle] wrapper (use a macro similar to libm_helper rather than enumerating everything manually) and is gated behind a new no-mangle Cargo feature. Running libc-test is also a good idea, that can come as a follow up if it is easier.

Also fyi this PR has a checked in binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants