store date of nightly version in separate field #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
| @@ -244,6 +244,17 @@ pub(crate) async fn finish_build( | |||
| debug!("updating build after finishing"); | |||
| let hostname = hostname::get()?; | |||
|
|
|||
| let rustc_date = match parse_rustc_date(rustc_version) { | |||
There was a problem hiding this comment.
Do we not want to return early in case the date couldn't be parsed instead?
There was a problem hiding this comment.
I wasn't sure about the possible edge cases. While I tested the parsing with all existing rustc_version contents in our production builds table, we have a handful of records where the version is empty.
So for now I wanted to just log an error. In the end, the build finished, even when the version couldn't be parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is helpful for two things I'm working on: