Improve formatting of rustwide log messages
#2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
commented
Nov 24, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Enables `tracing-subscriber/tracing-log` feature to get its support for formatting based on these messages custom attributes. Requires manually registering the registry to avoid `tracing-subscriber` attempting to register its own `tracing-log` instance as we've already registered one through `rustwide`.
Nemo157
force-pushed
the
tracing-log-fmt
branch
from
bc63255
to
f90f00b
Compare
|
Updated to use the direct registration APIs instead of the |
syphar
approved these changes
Nov 29, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
tracing-subscriber/tracing-logfeature to get its support for formatting based on these messages custom attributes. Requires manually registering the registry to avoidtracing-subscriberattempting to register its owntracing-loginstance as we've already registered one throughrustwide.fixes #2336