Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --allow-dirty imply --allow-staged #15013

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kornelski
Copy link
Contributor

Staged changes don't really need protecting, and --allow-dirty is stronger than --allow-staged, so it can imply --allow-staged to make usage of cargo fix less verbose.

Closes #14176

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-documenting-cargo-itself Area: Cargo's documentation Command-fix S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2025
@epage
Copy link
Contributor

epage commented Jan 4, 2025

As a reminder, the Cargo team's policy is that Issues need to be S-accepted before moving onto PRs

@epage epage marked this pull request as draft January 4, 2025 02:17
@rustbot rustbot added the A-cli-help Area: built-in command-line help label Jan 4, 2025
@kornelski
Copy link
Contributor Author

I don't know what else I can do to move the issue forward. My feature request hasn't been accepted nor rejected for months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-fix S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-fix: --allow-dirty to imply --allow-staged?
4 participants