Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Include compiler crashes in ICE defintion" #94

Merged
merged 1 commit into from
May 26, 2020

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented May 24, 2020

This reverts the ICE definition change at commit a3891cd.

Cherry picked 7bd1ec4 from #88

r? @pnkfelix

@chrissimpkins chrissimpkins requested a review from pnkfelix May 24, 2020 22:10
@pnkfelix
Copy link
Member

Thanks for pulling this out!

I'll file an issue to track doing this the "right way." (According to the cargo devs, one can use verbose output from cargo which will print the underlying error codes from rustc, at least at some verbosity level...)

@pnkfelix pnkfelix merged commit 82e234f into rust-lang:master May 26, 2020
@chrissimpkins chrissimpkins deleted the revert-ice-definition branch May 26, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants