Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate chapter numbering changes for new Ch. 17 #4042

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Sep 26, 2024

Warning

The Files view is probably going to make your browser pretty unhappy, because GitHub really has no idea how to render this many changes. A few options for reviewing this successfully:

  • Look at individual commits.
  • Filter by file type. You can exclude all the .rs files, for example, since they are simple renames.
  • Combine those two strategies!
  • Update all listings for the existing chs. 17–20 to be chs. 18–21 and updates all references to them in the text.
  • Update all references to the chapters outside listings.
  • Update all intra-textual links.

@chriskrycho chriskrycho marked this pull request as ready for review September 26, 2024 21:26
@chriskrycho chriskrycho force-pushed the async-chapter-with-listings branch 3 times, most recently from 925bb33 to 8f1ef1e Compare October 3, 2024 14:34
@chriskrycho chriskrycho force-pushed the async-chapter-with-listings branch 6 times, most recently from 57f5c20 to 56dce6e Compare October 8, 2024 14:51
@chriskrycho chriskrycho merged commit 859c4e0 into async-chapter Oct 8, 2024
6 checks passed
@chriskrycho chriskrycho deleted the async-chapter-with-listings branch October 8, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant