Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce LLVMFuzzerInitialize support #128

Merged
merged 12 commits into from
Jan 24, 2025
Merged

Introduce LLVMFuzzerInitialize support #128

merged 12 commits into from
Jan 24, 2025
+154 −10

Conversation

zi0Black
Copy link
Contributor

@zi0Black zi0Black commented Dec 21, 2024 •
edited
Loading

  • Added example_init to demonstrate the use of initialization code with the fuzz_target! macro.
  • Updated fuzz_target! macro to support an init parameter for executing initialization code before fuzzing.
  • Updated CI script to build and run the new example.

Should I update any doc with init usage example?

Is the example good enough? Maybe an example using static would be more meaningful.

Close after merge:

@zi0Black
Enhance fuzzing capabilities with LLVMFuzzerInitialize support
d561921 
- Added `example_init` to demonstrate the use of initialization code with the `fuzz_target!` macro.
- Updated `fuzz_target!` macro to support an `init` parameter for executing initialization code before fuzzing.
- Updated CI script to build and run the new example.
hanna-kruppe
hanna-kruppe reviewed Dec 27, 2024
View reviewed changes
Copy link

@hanna-kruppe hanna-kruppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this before I got around to it! Some questions/suggestions I had while skimming the diff. I'm not a maintainer, so this doesn't carry any weight one way or another, but I hope they're still useful.

example_init/fuzz/fuzz_targets/bigbang.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
fitzgen
fitzgen reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me with nitpick below addressed.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
fitzgen
fitzgen reviewed Jan 22, 2025
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
fitzgen
fitzgen reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good modulo one final suggestion for the doc comment example

src/lib.rs Outdated Show resolved Hide resolved
@zi0Black @fitzgen
Update init doc
57296bf 
Co-authored-by: Nick Fitzgerald <[email protected]>
fitzgen
fitzgen approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zi0Black
Copy link
Contributor Author

Rust fmt is my nemesis :(

@fitzgen fitzgen merged commit bc6ea8b into rust-fuzz:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanna-kruppe hanna-kruppe hanna-kruppe left review comments

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zi0Black @fitzgen @hanna-kruppe