Expand cluster implementation + fix _strip to work on clusters #251
Conversation
|
ah.. wait on this one. I just realized I need to add the addressOffset from the cluster to the expanded registers update - fixed it in 40c94d4 |
|
I have made some updates to address your concerns about multiple element clusters, and clusters with nested clusters and register arrays. I don't really have any good examples of SVD files with properly formatted clusters and arrays. I am doing this work because the TI MSPM0 SVD clusters are a cluster****. If you have any SVD files that you know are well formatted that have these types of structures I can analyze and add to my test case, please let me know. |
|
I changed the way it names clusters with multiple elements to match the SVD spec https://open-cmsis-pack.github.io/svd-spec/main/elem_special.html#elem_dimArrayIndex Since no delimiter is specified in the spec, I gave options for the end user to set the pre-index delimiter, and post-index delimiter if they wish. Also I gave an option to force a single element cluster to have an index. Details are in the readme changes. |
|
ok, latest pull request has print statements cleaned up, and I also refactored expand_cluster into two functions for readability |
|
I also added code yesterday that closes #249 |
cosmikwolf
changed the title
cosmikwolf
changed the title
|
LGTM. Please squash commits. |
cosmikwolf
force-pushed
the
expand_cluster
branch
from
0a94d66 to
1d9454a
Compare
|
Commits squashed |
|
Also, I would be interested in joining the embedded rust working group if you guys are looking for new members |
|
There are several groups. What exact one? This crate is under @rust-embedded/tools |
|
Anyway you should create a proposal first. See rust-embedded/wg#801 for example. And add this for vote on next meeting: rust-embedded/wg#804 |
Implemented _expand_cluster, and added an example.
It takes a string or an array of strings as arguments.
Added an example in /res/expand_cluster and updated the readme
closes: #246