Alternate rand, rand_r and srand implementation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sympatron
reviewed
Nov 14, 2024
|
Is this one good to go? |
Might be useful if your newlib assumes that, even with 32-bit integers. Also adds "rand" to list of features in "all" and fixes missing portable-atomic.
It's not actually that useful.
This then matches the stdlib.h declaration. Looking at the numbers generated, having that be a 16-bit value doesn't appear to affect the quality of the output significantly. It's certainly good enough for typical use cases.
jonathanpallant
force-pushed
the
updated-rand
branch
from
4c01b21 to
e069a28
Compare
diondokter
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #31 but removes the thread-safety (as the standard doesn't require it) and supports both 16-bit
c_intand 32-bitc_int(with RAND_MAX always beingc_int::MAX).