Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR: v0.29.0 #685

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Mar 25, 2024

In preparation for release add a dummy changelog entry and bump the version.

@tcharding
Copy link
Member Author

tcharding commented Mar 25, 2024

Looks to me like we can merge and release this even before the new hashes version is released, which is an interesting observation of our release process.

@apoelstra
Copy link
Member

While #673 is still open I think we should just get rid of the ranged dependency.

Or we could remove the ThirtyTwoByteHash trait in this release, but I don't think we want to do that.

@tcharding tcharding changed the title Bump version to 0.29.0 Release tracking PR: v0.29.0 Mar 26, 2024
@tcharding tcharding marked this pull request as draft March 26, 2024 19:22
@tcharding tcharding force-pushed the 03-26-release-secp branch 2 times, most recently from 7965fc0 to 86328b4 Compare April 2, 2024 00:14
@tcharding tcharding force-pushed the 03-26-release-secp branch 2 times, most recently from 4a0e6a2 to 7f1c9b0 Compare April 2, 2024 01:47
@tcharding tcharding marked this pull request as ready for review April 2, 2024 01:48
@tcharding
Copy link
Member Author

tcharding commented Apr 2, 2024

Changelog is done, this fella is ready to go after #688 merges.

@tcharding tcharding marked this pull request as draft April 2, 2024 01:51
In preparation for release add a changelog entry and bump the version.
@tcharding tcharding marked this pull request as ready for review April 2, 2024 20:55
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5f9baaa

@apoelstra apoelstra merged commit 6648126 into rust-bitcoin:master Apr 2, 2024
21 checks passed
@apoelstra
Copy link
Member

Tagged and published.

@tcharding tcharding deleted the 03-26-release-secp branch August 6, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants