Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialized signture improvements #658

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Serialized signture improvements #658

merged 3 commits into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. Deprecate capacity and is_empty 

    These functions always return the same value so are not useful and
actually calling them is a red flag.
    @Kixunil
    Kixunil committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7dac91d View commit details
    Browse the repository at this point in the history

  2. Implement Borrow<[u8]>, PartialEq<[u8]>, Hash 

    These traits were missing and could be useful if e.g. one wants to store
serialized signatures in a set/map and access them using `[u8]`.
    @Kixunil
    Kixunil committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    dc3eab7 View commit details
    Browse the repository at this point in the history

  3. Implement conversion traits 

    Converting signature to serialized signature and back is natural, so the
conversion traits should be implemented.
    @Kixunil
    Kixunil committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    62c839c View commit details
    Browse the repository at this point in the history