CI: Grep for exact error message #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo +nightly` output of panic recently changed breaking our grep statement by adding the code line and a newline. Grep for the exact second line of the error message.
|
I think CI will pass once this PR is on top of #640 |
apoelstra
added a commit
that referenced
this pull request
Aug 10, 2023
92778ef CI: Pin cc in ASAN no_std_test crate (Tobin C. Harding) 5e6dd8a CI: Use bash instead of sh (Tobin C. Harding) cf5f103 Target panic message at lib users (Tobin C. Harding) ec9c964 Allow stuff after unconditional panic (Tobin C. Harding) 3bbf083 no_std_test: Remove internal_features (Tobin C. Harding) cff7a3d CI: Grep for exact error message (Tobin C. Harding) 79e184f CI: Update MSRV pins (Tobin C. Harding) Pull request description: CI has a bunch of things broken. This is #640 followed by #639 followed by a few addition fixes to get CI green again. Includes clippy warnings in feature gated code which is not strictly necessary and a fix to a panic message, also not strictly necessary. ACKs for top commit: apoelstra: ACK 92778ef Tree-SHA512: f99b01e17fade7df394299bdb6bf385bec3f88d6568d43962238049b33a94c364d48c266acb358e72a48dd55a4aac6300ace6478b0821275b89cb86eba639d8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo +nightlyoutput of panic recently changed breaking our grep statement by adding the code line number and a newline.Grep for the exact second line of the error message. Note we use dots instead of version numbers to reduce the maintenance burden.