Update Bitcoin Core dependency to 0.21.2 #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
bitcoin-core-0.21.2
branch
from
4b1f879 to
58b9ee7
Compare
tcharding
changed the title
tcharding
force-pushed
the
bitcoin-core-0.21.2
branch
from
58b9ee7 to
0891148
Compare
tcharding
changed the title
tcharding
force-pushed
the
bitcoin-core-0.21.2
branch
from
0891148 to
7870b8d
Compare
af591f2068 Merge bitcoin/bitcoin#22858: [0.21] Final changes for 0.21.2
6c102a696e release: bump RC to 0 (-final)
f78570ef87 doc: mention bech32m/BIP350 in doc/descriptors.md
97d3500601 Merge bitcoin/bitcoin#22823: [0.21] Update version and release notes for 0.21.2rc2
b8f5fb7c6b build: bump version to 0.21.2rc2
82c5208ddc doc: update release notes for rc2
6ebb9d0e46 Merge bitcoin/bitcoin#22808: [0.21] 0.21.2rc2 backports
55a8a5b2df Merge bitcoin/bitcoin#22810: [0.21] qt: Pre-0.21.2rc2 translations update
d9b18c1290 Fix build with Boost 1.77.0
2d7f2606c1 ci: Run fuzzer task for the master branch only
2a7568999c qt: Pre-0.21.2rc2 translations update
3118a5eedf Merge bitcoin/bitcoin#22721: doc: add inital PR and author list to 0.21.2 release notes
2873e01c6a doc: add inital PR and author list to 0.21.2 release notes
89d148c8c6 qt: Translations update for 0.21.2rc1
e94e433762 doc: Update manual pages for 0.21.2
bf672ce25a build: Bump version to 0.21.2rc1
4b523c8f0a Merge bitcoin/bitcoin#22569: [0.21] Rate limit the processing of rumoured addresses
2a57108051 Avoid Appveyor compilation failure
a653aacbd6 Add logging and addr rate limiting statistics
aaa4833fc9 Functional tests for addr rate limiting
8df3e5bd84 Randomize the order of addr processing
83dfe6c65e Rate limit the processing of incoming addr messages
068ac69b56 Merge bitcoin/bitcoin#22578: [0.21] Additional backports
52778f4245 Merge bitcoin/bitcoin#22580: [0.21] Backport: Reset scantxoutset progress before inferring descriptors
55e941f5df test: Fix intermittent feature_taproot issue
681f728a35 ci: Build with --enable-werror by default, and document exceptions
89426c43fb ci: Fix macOS brew install command
080b47d9ce rpc: reset scantxoutset progress on finish
997e528a34 Merge bitcoin/bitcoin#22427: [0.21] gui: Backports for 0.21.2
e3f1da4bf3 qt: Draw "eye" sign at the beginning of watch-only addresses
6ca54ce2ae qt: Do not extend recent transaction width to address/label string
f220368220 qt: Do not use QClipboard::Selection on Windows and macOS.
bd2f4164c6 Merge bitcoin/bitcoin#22366: [0.21] fuzz: add missing ECCVerifyHandle to base_encode_decode
4c29b63cfb Merge bitcoin/bitcoin#22255: [0.21] wallet: Do not iterate a directory if having an error while accessing it
da816247f0 util: Properly handle -noincludeconf on command line
513613d8a8 Cleanup -includeconf error message
70eac6fcd0 Fix crash when parsing command line with -noincludeconf=0
c5357fa415 fuzz: add missing ECCVerifyHandle to base_encode_decode
926f76cb20 Merge bitcoin/bitcoin#22191: [0.21] gitian: Use custom MacOS code signing tool
7b0b201d10 wallet: Do not iterate a directory if having an error while accessing it
0fe60a84ae Use latest signapple commit
5313d6aed2 gitian: Remove codesign_allocate and pagestuff from MacOS build
27d691b6b5 gitian: use signapple to create the MacOS code signature
2f33e339a8 gitian: use signapple to apply the MacOS code signature
65ce833042 gitian: install signapple in gitian-osx-signer.yml
419f9b3b3b Merge bitcoin/bitcoin#22022: Final backports for 0.21.2rc1
09620b89f5 Update Windows code signing certificate
46320ba72f Remove user input from URI error message
f2a88986a1 p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind()
58c0742632 Merge bitcoin/bitcoin#21932: [0.21] depends: update Qt 5.9 source url
deff4e763e depends: update Qt 5.9 source url
8584a4460d doc: Archive and clean out release notes post-0.21.1
bbd89d23b3 Merge bitcoin/bitcoin#21860: [0.21] Backport update to Boost download URL
856de5bd5e build,boost: update download url.
194b9b8792 build: Bump RC to 0 (-final)
d97d0d31a6 doc: Merge release notes fragment, merge taproot description from wiki
5577e0a486 doc: Add PR and author list to release notes for 0.21.1
329eafa7f4 doc: Regenerate manual pages for 0.21.1rc1
e85dfdbf31 build: Bump version to 0.21.1rc1
ab20518191 gui: Pre-rc1 translations update
f8bbee425e Merge #21614: [0.21] test: Backports
b8af67eeef fuzz: cleanups for versionbits fuzzer
79cdb4a198 test: make sure non-IP peers get discouraged and disconnected
b765f41164 test: also check disconnect in denialofservice_tests/peer_discouragement
dfeb6c10bb test: use pointers in denialofservice_tests/peer_discouragement
e3b76b6c13 Merge #21701: [0.21] Speedy trial activation for Taproot
0fe5b6130c Merge #21520: [0.21] wallet: Avoid requesting fee rates multiple times during coin selection
cbd64c3a28 Add mainnet and testnet taproot activation params
ec7824396b chainparams: drop versionbits threshold to 90% for mainnnet and signet
600357306e versionbits: simplify state transitions
3acf0379e0 versionbits: Add explicit NEVER_ACTIVE deployments
b529222ad1 fuzz: test versionbits delayed activation
71917e01eb tests: test versionbits delayed activation
4cab84cfdf versionbits: Add support for delayed activation
f9517e6014 tests: clean up versionbits test
1c0164544c tests: test ComputeBlockVersion for all deployments
2e9e7f4329 tests: pull ComputeBlockVersion test into its own function
e358b43f7d Merge #21640: [0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it
f79189ca54 Test that signrawtx works when a signed CSV and CLTV inputs are present
7de019bc61 Introduce DeferringSignatureChecker and inherit with SignatureExtractor
0b9a046c1a Merge #21616: [0.21] build: link against -lsocket if required for *ifaddrs
1a9a2cb7dc net: add ifaddrs.h include
f6896dfde7 build: check if -lsocket is required with *ifaddrs
e99d6d0c7c rand: only try and use freeifaddrs if available
d61fb07da7 Rename CoinSelectionParams::effective_fee to m_effective_feerate
65fa43bda1 Merge #21469: BIP 350: Implement Bech32m and use it for v1+ segwit addresses (0.21 backport)
f2195d7c4a Backport invalid address tests
1e9671116f naming nits
7dfe406e20 Add signet support to gen_key_io_test_vectors.py
593e206627 Use Bech32m encoding for v1+ segwit addresses
8944aaa6d6 Add Bech32m test vectors
1485533092 Implement Bech32m encoding/decoding
5fc381e443 wallet: Move discard feerate fetching to CreateTransaction
bcd716670b wallet: Move long term feerate setting to CreateTransaction
34c89f92f3 wallet: Replace nFeeRateNeeded with effective_fee
48fc675163 wallet: Use existing feerate instead of getting a new one
a30fd40735 Merge #20901: [0.21.1]: rc1 Backports
1bad33f952 Merge #21490: [0.21] Backport versionbits tests
5a2d98c640 doc: Remove outdated comment
8426e3a8a1 fuzz: Bump FuzzedDataProvider.h
14e3f2a1c9 fuzz: Bump FuzzedDataProvider.h
a48c9d3161 fuzz: Update FuzzedDataProvider.h from upstream (LLVM)
6746cd078b doc: add signet to doc/bitcoin-conf.md
58975d5c0a doc: add signet to share/examples/bitcoin.conf
b35711efde Update vcpkg checkout commit.
e775b0a6dd tests: Add fuzzing harness for versionbits
3a12672419 GUI: Write PSBTs to file with binary mode
36ecf5eb87 tests: Test that a fully signed tx given to signrawtx is unchanged
0c471a5f30 tests: check never active versionbits
3ba9283a47 tests: more helpful errors for failing versionbits tests
4ef1e4bd40 test: disallow sendtoaddress/sendmany when private keys disabled
d6b5eb5fcc Disallow sendtoaddress and sendmany when private keys disabled
08dada8456 util: Disallow negative mocktime
95218ee95c net: Avoid UBSan warning in ProcessMessage(...)
4607019798 fix the unreachable code at feature_taproot
6dc58e9945 qt: Use "fusion" style on macOS Big Sur with old Qt
e2ebc8567a raise helpMessageDialog
a98f211940 Fix MSVC build after gui#176
bdc64c9030 qt: Stop the effect of hidden widgets on the size of QStackedWidget
7bc4498234 qt: Fix TxViewDelegate layout
b7086e69ff qt: Add TransactionOverviewWidget class
0dba346a56 qt: Use layout manager for Create Wallet dialog
7d8a10a6f4 Merge #20933: [0.21] doc: Archive release notes, Add template for minor release
b6d3502993 doc: Archive release notes, Add template for minor release
95ea54ba08 build: Bump RC to 0 (-final)
91f0632464 Merge #20929: doc: Move 0.21.0 release notes from wiki
66e6742a27 doc: Move 0.21.0 release notes from wiki
7bf3ed495b Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes"
bdce029191 test: add test for banning of non-IP addresses
c33fbab25c net: allow CSubNet of non-IP networks
15877d160c qt: Pre-rc5 translations update
4e7b4ce7eb build: Bump RC to rc5
6e28714da3 Merge #20850: [0.21] final rc5 backports
3308718a6b Revert "Add patch to make codesign_allocate compatible with Apple's"
e6ad8a6220 doc: Generate manual pages for 0.21.0rc4
212525337e build: Bump RC to rc4
93ce429f0e qt: Pre-rc4 translations update
ac125e960f Merge #20669: [0.21] final rc4 backports
b1c0f97483 [doc] Add permissions to the getpeerinfo help.
1fda7db64f rpc: Add missing description of vout in getrawtransaction help text
ef7a155cf0 qt: Align layout of checkboxes
35a10e4ebc Add patch to make codesign_allocate compatible with Apple's
e70ccb0bc4 doc: update -externalip documentation in tor.md
2c8482d0a2 doc: add tor.md section on how to get tor info via bitcoind
0c1fa78af1 doc: update tor.md address examples from onion v2 to v3
84e8d5467f doc: warn that incoming conns are unlikely when not using default ports
e4440eb67b doc: Add warnings for http interfaces limitations
85dabd1249 Removed redundant git pull from appveyor config.
249d61a382 Adjusted msvc compiler and linker settings to remove optimisations that are causing sporadic ABI issues on Visual Studio updates.
e7b53d4721 This change to the appveyor CI config for msvc builds reverses a change introduced in #19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release.
8273ea3b8d Move signet onion seed from v2 to v3
9ae536d368 build: Bump RC to rc3
e6d0fa3ef6 gui: pre-rc3 translations update
3fee499bc3 Merge #20612: [0.21] final rc3 backports
48134a09ad doc: Update wallet database installation guide for macOS
f51e1cb291 build: Use Homebrew's sqlite package if it is available
48f8929aad build, refactor: Check that Homebrew's qt5 package is actually installed
96124a2041 build: Check that Homebrew's berkeley-db4 package is actually installed
61e316e661 Don't set BDB flags when configuring without
ce13b99020 Add regression test for incorrect decoding
1caa32e3f2 Improve heuristic hex transaction decoding
0d3c140c4d test: add coverage for passing fee rate as a string
06c84232b3 wallet, bugfix: allow send to take string fee rate values
bead935470 Send and require SENDADDRV2 before VERACK
9e806887a8 Don't send 'sendaddrv2' to pre-70016 software
aa4b8ebfec Merge #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes
68bd88597a Merge #20505: [backport] build: Avoid secp256k1.h include from system
6313362553 Use the correct incremental fee constant in bumpfee help
6e4969f76f Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
54e1edcc2b Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
01b647b1a2 build: Avoid secp256k1.h include from system
9facca3ce0 Merge #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage
d47d16025e Merge #20485: [backport] wallet: Do not treat default constructed types as None-type
4e964094db Merge #20486: [backport] test: Fix intermittent issue in mempool_compatibility
7264bcd20f qt: Pre-rc2 translations update
ba19f9b490 build: Bump RC to rc2
17294c1820 Merge #20479: Fix QPainter non-determinism on macOS (0.21 backport)
3fae2f95f1 Merge #20475: [backport] RPC: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet
ab23a83400 Fix QPainter non-determinism on macOS
b1f59d55d9 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet
fa05d19bd6 test: Fix intermittent issue in mempool_compatibility
bf9548bc59 Merge #20431: [backport 0.21] tests: shrink feature_taproot transfer of funds tx
7ffac12545 tests: shrink feature_taproot transfer of funds tx
ca8cd893bb wallet: fix and improve upgradewallet error responses
99d56e3571 wallet: fix and improve upgradewallet result responses
fa69c2c784 wallet: Do not treat default constructed types as None-type
80496f9e81 build: Set msvc builds's CLIENT_VERSION_IS_RELEASE
2498b04ce8 Don't upgrade to HD split if it is already supported
c46c18b788 wallet: refactor GetClosestWalletFeature()
6cde7bb9b2 doc: Generate manual pages for 0.21.0rc1
463b316822 build: Bump version for 0.21.0rc1
fac4e136fa refactor: Change pointer to reference because it can not be null
831675c8dc Merge #20401: qt: Pre-splitoff translations update
80e32e120e Merge #20305: wallet: introduce fee_rate sat/vB param/option
e7986c51bc Merge bitcoin-core/gui#96: Slight improve create wallet dialog
c463f70fb0 Merge #20139: Wallet: do not return warnings from UpgradeWallet()
3457054c61 Merge #20346: script: modify security-check.py to use "==" instead of "is" for literal comparison
7c0d412a74 Merge #20405: p2p: avoid calculating onion address checksum when version is not 3
9636962889 [upgradewallet] removed unused warning param
d355a302d9 Break circuit earlier
bb6441b7a4 qt: Pre-splitoff translations update
c48e788246 Merge #18836: wallet: upgradewallet fixes and additional tests
1e17114917 Merge #20238: doc: Missing comments for signet parameters
37a4634811 Merge #20390: CI/Cirrus: Skip merge_base step for non-PRs
2fa085a5d7 Merge #20033: refactor: minor whitespace fixups, s/const/constexpr/ and remove template (followup to #19845)
0ede354367 Merge #20386: Silence false positive GCC warning in wallet/rpcwallet.cpp
fb7726e56d Merge #20395: ci: Use the previous build worker image in AppVeyor
406097c810 ci: Use the previous build worker image in AppVeyor
20e491ddcb CI/Cirrus: Skip merge_base step for non-PRs
ac64cec4ce gui: create wallet: add advanced section
c99d6f644a gui: create wallet: name placeholder
049feabf28 Add missing optional.h include
29c66ace5c Silence false positive GCC warning
543693b92b Merge #20378: wallet: fix potential division by 0 in WalletLogPrintf
28cb61646b Merge #19065: tests: Add fuzzing harness for CAddrMan
99fcc2b477 Merge #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp)
0ccb3addf6 tests: Remove no longer needed UBSan suppression (float-divide-by-zero in validation.cpp)
440f8d3abe fix potential devision by 0
0bd4929cd0 Merge #20284: addrman: ensure old versions don't parse peers.dat
d04a17a790 fuzz: Use ConsumeRandomLengthBitVector(...) in src/test/fuzz/connman and src/test/fuzz/net
e6bb9fde85 tests: Add fuzzing harness for CAddrMan
9bd1316697 Merge bitcoin-core/gui#120: Fix multiwallet transaction notifications
05e82d86b0 wallet: override minfee checks (fOverrideFeeRate) for fee_rate
9a670b4f07 wallet: update sendtoaddress, send RPC examples with fee_rate
be481b72e2 wallet: use MIN_RELAY_TX_FEE in bumpfee help
449b730579 wallet: provide valid values if invalid estimate mode passed
6da3afbaee wallet: update remaining rpcwallet fee rate units to BTC/kvB
173b5b5fe0 wallet: update fee rate units, use sat/vB for fee_rate error messages
8a486158cb Merge #20188: tests: Add fuzzing harness for CConnman
af8ec1d3e5 Merge #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness
027e51f715 Merge #20372: Avoid signed integer overflow when loading a mempool.dat file with a malformed time field
bcd142e479 Merge #20285: Remove references to CreateWalletFromFile
c82336c493 Remove references to CreateWalletFromFile
c2d8ba6265 Merge #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks
3c77b8009d fuzz: Improve coverage for CPartialMerkleTree fuzzing harness
d9f5132736 Merge #20344: wallet: fix scanning progress calculation for single block range
38ada892ed addrman: ensure old versions don't parse peers.dat
7f9835a05a wallet: remove fee rates from conf_target helps
b7994c01e9 wallet: add fee_rate unit warnings to bumpfee
410e471fa4 wallet: remove redundant bumpfee fee_rate checks
a0d4957473 wallet: introduce fee_rate (sat/vB) param/option
e21212f01b wallet: remove unneeded WALLET_BTC_KB_TO_SAT_B constant
6112cf20d4 wallet: add CFeeRate ctor doxygen documentation
3f72791613 wallet: fix bug in RPC send options
179ece4273 Merge #20218: test: Suppress epoll_ctl data race
ee11a412a5 Avoid signed integer overflow when loading a mempool.dat file with a malformed time field
155bf91c3b Merge #20368: ci: Remove redundant valgrind fuzz task
5e146022da wallet: fix scanning progress calculation for single block range
fa949b3c13 test: Suppress epoll_ctl data race
fa92cf29d9 ci: Remove redundant valgrind fuzz task
fa8dd34e91 Merge #20332: test: Mock IBD in net_processing fuzzers
42f950cb27 Merge #20322: test: Fix intermittent issue in wallet_listsinceblock
0b69bb90ee Merge #20355: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet
1dfe19e284 Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet
79a3b59cc7 Merge #20120: net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests
79b8f8d574 fuzz: Assert roundtrip equality for both addrv1 and addrv2 versions of CService
0e3a78a8ab fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet
b6121edf70 swapped "is" for "==" in literal comparison
4fd37d0a10 Merge #20292: test: Fix intermittent feature_taproot issue
05aeeee34f Merge #20339: ci: Run more ci configs on cirrus
663fd92b28 Merge #20266: wallet: fix change detection of imported internal descriptors
f70eb51b05 Merge #20318: build: Ensure source tarball has leading directory name
77777c8b5e ci: Run windows ci config on cirrus
3333d6942e ci: Run macos ci config on cirrus
fa8b1114e6 ci: Run arm ci config on cirrus
fa0795f54d ci: Replace TRAVIS_OS_NAME with CI_OS_NAME
fafce1a13a ci: Move documentation to correct config file
fa4234d877 test: Mock IBD in net_processing fuzzers
7e373294a5 Merge #20315: travis: Remove s390x build
4727c1ca24 Merge #20328: cirrus: Skip tasks on the gui repo main branch
66667acc53 cirrus: Skip tasks on the gui repo main branch
a0c00ff7c0 Merge #20298: macOS deploy: use the new plistlib API
c51c2753a4 Merge #20326: tests: Fix ecdsa_verify in test framework
65460c207c Merge #20324: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase
24d2d3341d QA: wallet_multiwallet: Check that recursive symlink directory and wallet.dat loops are ignored
69f59af54d Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks
568a1d7261 fix ecdsa verify in test framework
faf5fa7413 wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase
444412821e test: Fix intermittent issue in wallet_listsinceblock
f5cdc290d5 Merge #20316: test: Fix wallet_multiwallet test issue on Windows
faa2f06f5e scripted-diff: [build] Ensure source tarball has leading directory name
9bb078351b Merge #20308: wallet: Set bilingual error completely
fa00ff0399 test: Fix wallet_multiwallet test issue on Windows
d94777bd52 Merge #20302: net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)
fa2c3c0d96 ci: Set LC_ALL=C to allow running the s390x tests in qemu
fac0517836 travis: Remove s390x build
090b8385af Set bilingual error completely
f33e332541 Merge #20303: fuzz: Assert expected DecodeHexTx behaviour when using legacy decoding
6954e4d16c Merge #20283: test: Only try witness deser when checking for witness deser failure
83650e4df5 Merge #20199: wallet: ignore (but warn) on duplicate -wallet parameters
d7901ab8d2 fuzz: Assert expected DecodeHexTx behaviour when using legacy decoding
6760088015 Merge #20300: fuzz: Add missing ECC_Start to descriptor_parse test
deb2b27c0d Merge #20294: ci: Run more ci configs on cirrus
5f9c0b6360 wallet: Remove -upgradewallet from dummywallet
a314271f08 test: Remove unused wallet.dat
bf7635963c tests: Test specific upgradewallet scenarios and that upgrades work
4b418a9dec test: Add test_framework/bdb.py module for inspecting bdb files
092fc43485 tests: Add a sha256sum_file function to util
0bd995aa19 wallet: upgrade the CHDChain version number when upgrading to split hd
8e32e1c41c wallet: remove nWalletMaxVersion
bd7398cc62 wallet: have ScriptPubKeyMan::Upgrade check against the new version
ed9f547750 Merge #20299: test: Fix intermittent rpc_net issue
5cafe2b25c fuzz: Add missing ECC_Start to descriptor_parse test
1209b6c692 Merge #20212: net: fix output of peer address in version message
f1f433e8ca Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)
fa2ecadd0d test: Fix intermittent rpc_net issue
04a69c200e macOS deploy: use the new plistlib API
88776c2926 Merge #20245: test: Run script_assets_test even if built --with-libs=no
5d32009f1a Merge #20220: wallet, rpc: explicit fee rate follow-ups/fixes for 0.21
17c6fb176a Merge #20282: wallet: change upgradewallet return type to be an object
fa8e494554 ci: Run ci configs on cirrus
fab900802d ci: Bump timeout factor
95bde34a71 Merge #20237: net: Hardcoded seeds update for 0.21
50eb0c2512 Small improvements to the Taproot functional tests
fac865b72d test: Fix intermittent feature_taproot issue
fa1dea19fc test: Fix deser issue in create_block
fa762a3fd4 test: Remove unused unnamed parameter from block.serialize call
58cfbc38e0 Ignoring (but warn) on duplicate -wallet parameters
218fe60d91 Merge #20290: fuzz: Fix DecodeHexTx fuzzing harness issue
5174b534da Merge #20289: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService
8387f832d6 Merge #20187: Addrman: test-before-evict bugfix and improvements for block-relay-only peers
28f8cb13d4 fuzz: Fix DecodeHexTx fuzzing harness issue
c2cf8a18c2 fuzz: Check for addrv1 compatibility before using addrv1 serializer on CService
ca18860563 Merge #20263: Update assumed chain params
ef4c7c4e0b Merge #18788: tests: Update more tests to work with descriptor wallets
b6a00e76ab Merge #20279: doc: release process updates/fixups
fae45c34d1 test: Only try witness deserialize when checking for witness deserialize failure
c5ec0367d7 Merge #20165: Only relay Taproot spends if next block has it active
2ead31fb1b [wallet] Return object from upgradewallet RPC
fa90ba36d3 Update assumed chain params
867dbeba5f Merge #20281: docs: Correct getblockstats documentation for (sw)total_weight
26d7941224 Merge #20230: wallet: Fix bug when just created encrypted wallet cannot get address
c7b7e0a692 tests: Make only desc wallets for wallet_multwallet.py --descriptors
d4b67ad214 Avoid creating legacy wallets in wallet_importdescriptors.py
6c9c12bf87 Update feature_backwards_compatibility for descriptor wallets
9a4c631e1c Update wallet_labels.py to not require descriptors=False
242aed7cc1 tests: Add a --legacy-wallet that is mutually exclusive with --descriptors
388053e172 Disable some tests for tool_wallet when descriptors
47d3243160 Make raw multisig tests legacy wallet only in rpc_rawtransaction.py
59d3da5bce Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py
25bc5dccbf Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py
0bd1860300 Avoid dumpprivkey and watchonly behavior in rpc_signrawtransaction.py
08067aebfd Add script equivalent of functions in address.py
86968882a8 Add descriptor wallet output to tool_wallet.py
3457679870 Use separate watchonly wallet for multisig in feature_nulldummy.py
a42652ec10 Move import and watchonly tests to be legacy wallet only in wallet_balance.py
4b871909d6 Use importdescriptors for descriptor wallets in wallet_bumpfee.py
c2711e4230 Avoid dumpprivkey in wallet_listsinceblock.py
553dbf9af4 Make import tests in wallet_listtransactions.py legacy wallet only
dc81418fd0 Use a separate watchonly wallet in rpc_fundrawtransaction.py
a357111047 Update wallet_importprunedfunds to avoid dumpprivkey
f1fcbdea25 Merge #20271: doc: Document that wallet salvage is experimental
0c2eb7f8de Merge #20262: tests: Skip --descriptor tests if sqlite is not compiled
5a6f3c5a01 Merge #20080: Strip any trailing `/` in -datadir and -blocksdir paths
e5f3e95a8e doc: fix getchaintxstats fields in release-process.md
5d9917464a docs: Correct getblockstats documentation for (sw)total_weight
241434200e refactor: qt: Use vQueueNotifications.clear()
89836a82ee style: minor improvements as a followup to #19845
3d0556d410 Increase feature_taproot inactive test coverage
525cbd425e Only relay Taproot spends if next block has it active
fab94534b6 doc: Document that wallet salvage is experimental
5bff82540b [gui] create wallet: smarter checkbox toggling
bd93fc9945 Fix change detection of imported internal descriptors
7411876c75 Ensure a legacy wallet for BDB format check
586640381a Skip --descriptor tests if sqlite is not compiled
42b66a6b81 Merge #20186: wallet: Make -wallet setting not create wallets
8e9e190ea5 Merge #20257: Update secp256k1 subtree to latest master
5b82f253b6 Merge #20195: build: fix mutex detection when building bdb on macOS
2e24197117 Merge #20115: cli: -netinfo quick updates/fixups for 0.21
f3727fd735 Merge #20156: build: Make sqlite support optional (compile-time)
924a4ff7eb Merge #20242: fuzz: Properly initialize PrecomputedTransactionData
6196cf77e5 Merge #19753: p2p: don't add AlreadyHave transactions to recentRejects
0be29000c0 rpc: update conf_target helps for correctness/consistency
778b9be406 wallet, rpc: fix send subtract_fee_from_outputs help
603c005083 wallet: add rpc send explicit fee rate coverage
dd341e602d wallet: add sendtoaddress/sendmany explicit fee rate coverage
44e7bfa603 wallet: add walletcreatefundedpsbt explicit fee rate coverage
6e1ea4273e test: refactor for walletcreatefundedpsbt fee rate coverage
3ac7b0c6f1 wallet: fundrawtx fee rate coverage, fixup ParseConfirmTarget()
3f512f3d56 Merge #20258: tests: Remove getnettotals/getpeerinfo consistency test
778cd0d88d [tests] Remove getnettotals/getpeerinfo consistency test
db26eeba71 Merge #19877: [test] clarify rpc_net & p2p_disconnect_ban functional tests
488b77f72e Merge #20256: qt: Pre-splitoff translations update
5803f5f5f6 Update secp256k1 subtree to latest master
6c0259fc2f Squashed 'src/secp256k1/' changes from c6b6b8f1bb..3967d96bf1
47ff5098ad [test] Clarify setup of node topology.
989e579d07 qt: Make transaction notification queue wallet specific
7b3b2303f4 move-only: Define TransactionNotification before TransactionTablePriv
0672522aed [move-only, test]: Match test order with run order
2d8eba8f84 wallet: combine redundant bumpfee invalid params and args tests
1697a40b6f wallet: improve bumpfee error/help, add explicit fee rate coverage
ad5cef5dfd doc: Update data directory path comments
b19e88230f util: Add StripRedundantLastElementsOfPath function
a193f969ee qt: Pre-splitoff translations update
16d9bfc417 Avoid test-before-evict evictions of current peers
e8b215a086 Refactor test for existing peer connection into own function
4fe338ab3e Call CAddrMan::Good() on block-relay-only peer addresses
daf5553126 Avoid calling CAddrMan::Connected() on block-relay-only peer addresses
55b1ffcd25 Merge bitcoin-core/gui#116: Fix unreasonable default size of the main window without loaded wallets
d0a829e963 build: fix mutex detection when building bdb on macOS
d419fdedbe [net processing] Don't add AlreadyHave txs to recentRejects
83363f7b62 Merge #20167: test: Add test for -blockversion
c1564baf3b Merge #19124: doc: Document ALLOW_HOST_PACKAGES dependency option
67d4643a1a Merge #20152: doc: Update wallet files in files.md
fa463f1163 Merge #20247: fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 serialization.
903f3d0627 fuzz: Check for addrv1 compatibility before using addrv1 serializer
fa9b48549c test: Add test for -blockversion
fa3967efdb test: Replace ARRAYLEN with C++11 ranged for loop
fafc529053 test: Run AssetTest even if built --with-libs=no
faf58ab139 ci: Add --with-libs=no to one ci config
9c08f3332c doc: Missing comments for signet parameters
fa56d56d4e fuzz: Properly initialize PrecomputedTransactionData
7b2e42ecc4 qt: Add WalletFrame::sizeHint
398045ba8b cli -netinfo: print oversized/extreme ping times as "-"
773f4c99c0 cli -netinfo: handle longer tor v3 local addresses
33e987452f cli -netinfo: make age column variable-width
f8a1c4d946 cli -netinfo: various quick updates and fixes
6866259fab net: Hardcoded seeds update for 0.21
36e875b4c5 contrib: Add new versions to makeseeds.py and update gitignore
fc5721723d wallet: fix SetFeeEstimateMode() error message
052427eef1 wallet, bugfix: fix bumpfee with explicit fee rate modes
d67883d01e Merge bitcoin-core/gui#43: bugfix: Call setWalletActionsEnabled(true) only for the first wallet
bf6855a909 wallet: Fix bug when just created encrypted wallet cannot get address
49984b44cf Merge bitcoin-core/gui#71: Fix visual quality of text in QR image
9af7c1993b Merge #20216: wallet: fix buffer over-read in SQLite file magic check
9453fbf5a0 Merge #20: Wrap tooltips in the intro window
88271184e8 Merge #20112: test: Speed up wallet_resendwallettransactions with mockscheduler RPC
7012db2a6b Merge #20176: test: Fix intermittent issue in p2p_feefilter
1cb4e339f9 Merge #20039: test: Convert amounts from float to decimal
56a461f727 wallet: fix buffer over-read in SQLite file magic check
dda18e7310 Merge #20214: test: Fix rpc_net intermittent issue
fa5f46600f test: Fix rpc_net intermittent issue
5aadd4be18 Convert amounts from float to decimal
01476a88a6 wallet: Make -wallet setting not create wallets
b46f37ba5e Merge #20198: Show name, format and if uses descriptors in bitcoin-wallet tool
47fc883106 Merge #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods
af3b0dfc54 net: fix output of peer address in version message
0f86e7f128 Merge #20157: Bugfix: chainparams: Add missing (always enabled) Taproot deployment for Signet
fa4074b395 Show name, format and if uses descriptors in bitcoin-wallet tool
bbb42a6896 RPC: createwallet: Nicer error message if descriptor wallet requested and sqlite support not compiled in
6608fec332 GUI: Create Wallet: Nicely disable descriptor wallet checkbox if sqlite support not compiled in
7b54d768e1 Make sqlite support optional (compile-time)
2d5793c016 Bugfix: chainparams: Add missing (disabled) Taproot deployment for Signet
3c7d9ab8c8 test: Move (dis)?connect_nodes globals into TestFramework as helpers
4b16c61461 scripted-diff: test: Replace uses of (dis)?connect_nodes global
be386840d4 test: Replace use of (dis)?connect_nodes globals
79ef8324d4 tests: Add fuzzing harness for CConnman
f5bd46a4cc Merge #20125: rpc, wallet: Expose database format in getwalletinfo
45385018e1 Merge #20162: p2p: declare Announcement::m_state as uint8_t, add getter/setter
4f807348af Merge #20185: doc: Merge release notes
fa38093bee doc: Merge release notes
4769942d90 Merge #19624: Warn on unknown rw_settings
fa5a91a352 test: Fix typo (one tx is enough) in p2p_feefilter
d9d9a29352 Merge #20179: test: Fix intermittent issue in wallet_import_rescan
152ddb3197 Merge #20180: test: Fix -Wunused-function warnings if configured --without-libs
62af467ff0 Merge #20082: [bugfix] random: fixes read buffer to use min rather than max
5f720544f3 wallet: Add GetClosestWalletFeature function
842ae3842d wallet: Add utility method for CanSupportFeature
a1e0359618 Merge #19986: refactor: clean up -Wlogical-op warning in wallet/scriptpubkeyman.cp
c92aa8357c Merge #19911: net: guard vRecvGetData with cs_vRecv and orphan_work_set with g_cs_orphans
76bbcc414f test: Fix -Wunused-function warning if configured --without-libs
faab86f6c8 test: Fix intermittent issue in wallet_send
faca3734c0 test: Fix intermittent issue in wallet_import_rescan
80c8a02f1b Merge #20159: test: mining_getblocktemplate_longpoll.py improvements (use MiniWallet, add logging)
fa3af2c0d3 test: Fix intermittent issue in p2p_feefilter
5d644778da Merge #20169: Taproot follow-up: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract
b3527fd2e9 Merge #20168: contrib: Fix gen_key_io_test_vectors.py imports
c8abbc9d1f p2p: declare Announcement::m_state as uint8_t, add getter/setter
b128b56672 test: add logging for mining_getblocktemplate_longpoll.py
8ee3536b2b test: remove unused helpers random_transaction(), make_change() and gather_inputs()
9e8d2bd076 Merge bitcoin-core/gui#97: Relax GUI freezes during IBD (when using wallets)
fa68755364 contrib: Fix gen_key_io_test_vectors.py imports
fa7fb0e442 test: Default blockversion to 4 in feature_block
fddce7e199 test: use MiniWallet for mining_getblocktemplate_longpoll.py
fa2b778d0c test: Remove unused -blockversion from tests
cb21d864c5 Merge #19401: QA: Use GBT to get block versions correct
2947ae6f85 Merge #20035: signet: Fix uninitialized read in validation
82d3596dfe Merge #20161: Minor Taproot follow-ups
51365674e8 script: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract
fa723e3d43 Initialize default-initialized uint256 consensus params to zero explicitly
cbb5f3a2d5 Merge #19836: rpc: Properly deserialize txs with witness before signing
1d22300b99 Address functional test nits
5669642a0b docs: mention BIPs 340-342 in doc/bips.md
9ad7cd2887 Merge #20090: [doc] Tiny followups to new getpeerinfo connection type field
9855422e65 Merge #17428: p2p: Try to preserve outbound block-relay-only connections during restart
7b5bd3102e test: add getnetworkinfo network name regression tests
9a75e1e569 rpc: update GetNetworksInfo() to not return unsupported networks
ba8997fb2e net: update GetNetworkName() with all enum Network cases
0d22482353 Merge #20002: net, rpc, cli: expose peer network in getpeerinfo; simplify/improve -netinfo
624bab00dd test: add coverage for getwalletinfo format field
538be4219a wallet: fix importdescriptor silent fail
711ddce943 Merge #20131: test: Remove unused nVersion=1 in p2p tests
560dea9b26 Merge #19770: RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions")
e3b474c548 Merge #20140: Restore compatibility with old CSubNet serialization
fa729cdb2c doc: Move assumed-values doxygen comments to header
fa64892b82 signet: Fix uninitialized read in validation
3956165903 Merge #17775: DecodeHexTx: Try case where txn has inputs first
defe48a51f doc: Update wallet files in files.md
3caee16946 Merge #19953: Implement BIP 340-342 validation (Schnorr/taproot/tapscript)
8ed37f6c84 Merge #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets
f2e6d14430 Merge #20147: Update libsecp256k1 (endomorphism, test improvements)
661fe5d65c Merge #20146: net: Send post-verack handshake messages at most once
5e737a0092 rpc, wallet: Expose database format in getwalletinfo
52380bf304 Squashed 'src/secp256k1/' changes from 8ab24e8dad..c6b6b8f1bb
9e5626d2a8 Update libsecp256k1 subtree to latest master
c2c4dbaebd Merge #19988: Overhaul transaction request logic
c4a29d0a90 Update wallet_multiwallet.py for descriptor and sqlite wallets
310b0fde04 Run dumpwallet for legacy wallets only in wallet_backup.py
6c6639ac9f Include sqlite3 in documentation
f023b7cac0 wallet: Enforce sqlite serialized threading mode
6173269866 Set and check the sqlite user version
9d3d2d263c Use network magic as sqlite wallet application ID
9af5de3798 Use SQLite for descriptor wallets
9b78f3ce8e walletutil: Wallets can also be sqlite
ac38a87225 Determine wallet file type based on file magic
6045f77003 Implement SQLiteDatabase::MakeBatch
727e6b2a4e Implement SQLiteDatabase::Verify
b4df8fdb19 Implement SQLiteDatabase::Rewrite
010e365906 Implement SQLiteDatabase::TxnBegin, TxnCommit, and TxnAbort
ac5c1617e7 Implement SQLiteDatabase::Backup
f6f9cd6a64 Implement SQLiteBatch::StartCursor, ReadAtCursor, and CloseCursor
bf90e033f4 Implement SQLiteBatch::ReadKey, WriteKey, EraseKey, and HasKey
7aa45620e2 Add SetupSQLStatements
6636a2608a Implement SQLiteBatch::Close
93825352a3 Implement SQLiteDatabase::Close
a0de83372b Implement SQLiteDatabase::Open
3bfa0fe125 Initialize and Shutdown sqlite3 globals
5a488b3d77 Constructors, destructors, and relevant private fields for SQLiteDatabase/Batch
ca8b7e04ab Implement SQLiteDatabaseVersion
7577b6e1c8 Add SQLiteDatabase and SQLiteBatch dummy classes
e87df82580 Add sqlite to travis and depends
54729f3f4e Add libsqlite3
6272604bef refactor: enable -netinfo to add future networks (i2p, cjdns)
5b57dc5458 RPC: getpeerinfo: Wrap long help line for bytesrecv_per_msg
d681a28219 RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions")
da0988daf1 scripted-diff: rename vRecvGetData
ba951812ec Guard vRecvGetData (now in net processing) with its own mutex
2d9f2fca43 Move vRecvGetData to net processing
673247b58c Lock before checking if orphan_work_set is empty; indicate it is guarded
8803aee668 Move m_orphan_work_set to net_processing
99a1d572ea Merge #18750: build: optionally skip external warnings
82fd40216c refactor: promote some -netinfo localvars to class members
5133fab37e cli: simplify -netinfo using getpeerinfo network field
4938a109ad rpc, test: expose CNodeStats network in RPC getpeerinfo
6df7882029 net: add peer network to CNodeStats
9efa55c715 Merge #20130: Wallet: remove db mode string
3750f664b3 Merge #20129: tests: don't export in6addr_loopback
fa1f6f237d net: Send post-verack handshake messages at most once
e21b824386 Merge #20109: Release notes and followups from 19339
9c47cb29f9 [Rename only] Rename orphan_work_set to m_orphan_work_set.
fa299ac273 test: Speed up wallet_resendwallettransactions test with mockscheduler RPC
3333077823 rpc: Adjust witness-tx deserialize error message
ec0453cd57 Merge bitcoin-core/gui#102: Fix SplashScreen crash when run with -disablewallet
cd6e193d4c Merge #20126: test: p2p_leak_tx.py improvements (use MiniWallet, add p2p_lock acquires)
ad90dd9f31 Merge #20141: Avoid the use of abs64 in timedata
135afa749c wallet: remove db mode string
d1292f25f2 Avoid the use of abs64 in timedata
0e2a5e448f tests: dumping and minimizing of script assets data
4567ba034c tests: add generic qa-asset-based script verification unit test
f06e6d0345 tests: functional tests for Schnorr/Taproot/Tapscript
3c226639eb tests: add BIP340 Schnorr signature support to test framework
206fb180ec --- [TAPROOT] Tests ---
d7ff237f29 Activate Taproot/Tapscript on regtest (BIP 341, BIP 342)
e9a021d7e6 Make Taproot spends standard + policy limits
865d2c37e2 --- [TAPROOT] Regtest activation and policy ---
72422ce396 Implement Tapscript script validation rules (BIP 342)
330de894a9 Use ScriptExecutionData to pass through annex hash
8bbed4b7ac Implement Taproot validation (BIP 341)
0664f5fe1f Support for Schnorr signatures and integration in SignatureCheckers (BIP 340)
5de246ca81 Implement Taproot signature hashing (BIP 341)
886be97af5 Ignore incorrectly-serialized banlist.dat entries
883cea7dea Restore compatibility with old CSubNet serialization
fd9a0060f0 Report and verify expirations
86f50ed10f Delete limitedmap as it is unused now
cc16fff3e4 Make txid delay penalty also apply to fetches of orphan's parents
173a1d2d3f Expedite removal of tx requests that are no longer needed
de11b0a4ef Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
242d16477d Change transaction request logic to use txrequest
5b03121d60 Add txrequest fuzz tests
3c7fe0e5a0 Add txrequest unit tests
da3b8fde03 Add txrequest module
f79a4a8952 Merge #19998: net: Add CNode::ConnectedThroughNetwork member function
ba8950ee01 build: optionally skip external warnings
faad92fe1c test: Remove unused nVersion=1 in p2p tests
9eb590894f Add TaggedHash function (BIP 340)
450d2b2371 --- [TAPROOT] BIP340/341/342 consensus rules ---
5d62e3a68b refactor: keep spent outputs in PrecomputedTransactionData
8e4d62280e tests: don't export in6addr_loopback
af22322dab Merge #20119: BIP155 follow-ups
5b77f8098d test: add p2p_lock acquires in p2p_leak_tx.py
cc8c6823b4 test: use MiniWallet for p2p_leak_tx.py
56f9dba015 Only relay IPv4, IPv6, Tor addresses
79f3d9b932 Mention BIP155 in doc/bips.md
0b2abaa666 Merge #19954: Complete the BIP155 implementation and upgrade to TORv3
41dca087b7 [trivial] Extract connection type doc into file where it is used.
3069b56a45 [doc] Improve help for getpeerinfo connection_type field.
c056064a4a gui: Fix SplashScreen crash when run with -disablewallet
88197b0769 [doc] release notes for max fee checking
dcf0cb4776 tor: make a TORv3 hidden service instead of TORv2
353a3fdaad net: advertise support for ADDRv2 via new message
201a4596d9 net: CAddress & CAddrMan: (un)serialize as ADDRv2
a490d074b3 doc: Add anchors.dat to files.md
0a85e5a7bc p2p: Try to connect to anchors once
5543c7ab28 p2p: Fix off-by-one error in fetching address loop
4170b46544 p2p: Integrate DumpAnchors() and ReadAnchors() into CConnman
bad16aff49 p2p: Add CConnman::GetCurrentBlockRelayOnlyConns()
c29272a157 p2p: Add ReadAnchors()
567008d2a0 p2p: Add DumpAnchors()
12a1c3ad1a Merge #20107: doc: Collect release-notes snippets
6854dbdc88 Merge #20076: doc: Update and improve files.md
1d3ec2a1fd Support bypassing range check in ReadCompactSize
380705ef4f Merge #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster
c201d73df3 style and nits for fee-checking in BroadcastTransaction
d9de00b3e0 Merge #20105: [net] Remove CombinerAll
faa0847dec doc: Add release notes for #20101
392c6f4fb2 Merge #20101: rpc: change no wallet loaded message to be clearer
faf2999e25 cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster
1afcd41a90 [net] Remove CombinerAll
b337bd7bc0 Merge #20065: fuzz: Configure check for main function
9dd4de2832 Merge #20027: Use mockable time everywhere in net_processing
b6834e312a Avoid 'timing mishap' warnings when mocking
ec3916f40a Use mockable time everywhere in net_processing
907f142fc7 rpc: change no wallet loaded message to be clearer
bd5215103e random: fixes read buffer resizing in RandAddSeedPerfmon
283a73d7ea Merge #20092: util: Do not use gArgs global in ArgsManager member functions
db88db4727 Merge #19339: validation: re-delegate absurd fee checking from mempool to clients
8bd2b4e784 refactor: rename scriptPubKey in VerifyWitnessProgram to exec_script
107b57df9f scripted-diff: put ECDSA in name of signature functions
f8c099e220 --- [TAPROOT] Refactors ---
d8cd7b137f Merge #20095: CI: Bump vcpkg commit ID to get new msys mirror list
c83155b406 Bump vcpkg commit ID to get new msys mirror list
d103484fe8 util: Do not use gArgs global in ArgsManager member functions
2dc79c4264 doc: Update and improve files.md
b048b275d9 [validation] Remove absurdfee from accepttomempool
932564b9cf scripted-diff: update max-fee-exceeded error message to include RPC
8f1290c601 [rpc/node] check for high fee before ATMP in clients
875e1ccc9f Merge #19947: Test: Cover "change_type" option of "walletcreatefundedpsbt" RPC
dde104963b Merge #20064: RPC: remove duplicate line in getblock help
fae7a1c188 fuzz: Configure check for main function
cce1513179 Merge #19723: Ignore unknown messages before VERACK
f0fd132226 Merge #20072: ci: Build Arm64 on Travis without functional tests
2f7a53cc9d Merge #20069: test: Mention commit id in scripted diff error
06314fbb55 Merge #20071: ci, lint: Remove usage of TRAVIS_COMMIT_RANGE
a91ab86fae lint: Use TRAVIS_BRANCH in lint-git-commit-check.sh
c11dc995c9 lint: Don't use TRAVIS_COMMIT_RANGE in whitespace linter
1b41ce8f5f lint: Don't use TRAVIS_COMMIT_RANGE for commit-script-check
33df8d46bb ci: Build Arm64 on Travis without functional tests
3984b78cd7 test: Add tests for CNode::ConnectedThroughNetwork
49fba9c1aa net: Add CNode::ConnectedThroughNetwork member function
3491bf358a test: Mention commit id in scripted diff error
d4dde24034 net: Add CNode::m_inbound_onion data member
54fc96ffa7 Merge #19956: rpc: Improve invalid vout value rpc error message
1885ad3546 RPC: remove duplicate line in getblock help
a56e9f5670 test: Assert exclusive PSBT funding options
171cd05ae3 Merge #20034: test: Get rid of default wallet hacks
d9935222d5 Merge #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scopeId to m_scope_id
597488d37c Merge #19871: doc: Clarify scope of eviction protection of outbound block-relay peers
f36887fa47 net: rename CNetAddr scopeId to m_scope_id, improve code doc
5cb5fd3005 test: add test coverage for CNetAddr ipv6 scoped addresses
64bc5efd39 test: Assert PSBT change type
df2129a234 Merge #19991: net: Use alternative port for incoming Tor connections
99992e7832 doc: Collect release-notes snippets
60ec57b3d7 Merge #20055: rpc: Set HTTP Content-Type in bitcoin-cli
a6a993a888 Merge #20060: refactor: fix -Wbraced-scalar-init warning in validation tests
82b70f15c7 refactor: fix -Wbraced-scalar-init warning in validation tests
69a73803df Merge #20058: Update transifex slug for 0.21
7532c9a221 qt: Periodic translations update
598e3b1ed3 tx: Update transifex slug for 0.21
96571b3d4c doc: Update onion service target port numbers in tor.md
bb145c9050 net: Extend -bind config option with optional network type
92bd3c1da4 net, refactor: Move AddLocal call one level up
57f17e57c8 net: Pass onion service target to Tor controller
a0185d90a7 Merge #18309: zmq: Add support to listen on multiple interfaces
7eab781a14 rpc: Set HTTP Content-Type in bitcoin-cli
9fc2f011ba Merge #20048: chainparams: do not log signet startup messages for other chains
6fccad7f71 signet: do not log signet startup messages for other chains
40aab35e98 Merge #19253: Tests: tidy up address.py and segwit_addr.py
e66870c5a4 zmq: Append address to notify log output
241803da21 test: Add zmq test to support multiple interfaces
f471a3be00 scripted diff: Improve invalid vout value rpc error message
3487e421a7 Merge #20004: test: Add signet witness commitment section parse tests
72affcb16c Merge #19802: doc: elaborate on release notes wrt netmasks
7b7cb70f4c Merge #19498: Tidy up ProcessOrphanTx
301959fa74 Merge #20043: doc: Add 19501 release notes
4f5ae52738 Merge #20006: Fix misleading error message: Clean stack rule
5c435c78e3 Merge #20036: signet: Add assumed values for default signet
fa710a6d67 doc: Add 19501 release notes
faf60dee34 doc: Remove double-whitespace from help string, other whitespace fixups
1769828684 Merge #19501: send* RPCs in the wallet returns the "fee reason"
36f5a58c02 Merge #19960: build: The vcpkg tool has introduced a proper way to use manifests
c7ad94428a Merge #19958: doc: Better document features of feelers
95fedd33a2 refactor: Clean up -Wlogical-op warning
de4b7f25ac Merge #20015: doc: Added default signet config for linearize script
9e6f56f6ea Merge #19984: log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)"
8aa6178961 Merge #20003: net: Exit with error message if -proxy is specified without arguments (instead of continuing without proxy server)
fac966142e signet: Add assumed values for default signet
712f95d332 Update msvc build to use new vcpkg manifest
d82b2c6e65 Merge #19898: log: print unexpected version warning in validation log category
ec9b4492eb Merge #19630: Cleanup fee estimation code
c1585bca8d test: Get rid of default wallet hacks
ed3acda33b test, refactor: add default_wallet_name and wallet_data_filename variables
fa29b5ae66 test: Add signet witness commitment section parse tests
fa23308e9a Remove gArgs global from CreateChainParams to aid testing
6af9b31bfc Merge #19107: p2p: Move all header verification into the network layer, extend logging
e36aa351a3 Merge #19969: Send RPC bug fix and touch-ups
e3f07851f0 refactor: Rename TorController::target to m_tor_control_center
fdd3ae4d26 net, refactor: Refactor CBaseChainParams::RPCPort function
a5266d4546 net: Add alternative port for onion service
b3273cf403 net: Use network byte order for in_addr.s_addr
7ea649946d Merge #20028: test: Check that invalid peer traffic is accounted for
5db44c740e Merge #20014: doc: Mention signet in -help output
69cf5d4eeb [test] Make sure send rpc returns fee reason
655937ebcb Merge #19845: net: CNetAddr: add support to (un)serialize as ADDRv2
2552702000 Merge #15367: feature: Added ability for users to add a startup command
090530cc24 feature: Added ability for users to add a startup command
faa94cb167 test: Check that invalid peer traffic is accounted for
fae243f0cb test: Remove confusing cast to same type (int to int)
c95784e3d3 Merge #20016: uint256: 1 is a constant
e7e6f0bf18 Merge #20026: test: typo in a functional test doc
4cc7171c98 wallet: no need for duplicate storage for ABANDON_HASH constant
82cf4641f4 scripted-diff: Replace UINT256_ONE() with uint256::ONE
183f308fff uint256: Update constructors to c++11, make ONE static
a5a6965157 [Trivial] python help message
d5863c0b3e [send] Make send RPCs return fee reason
055abfbc5a Merge #20023: test: remove unused constants in functional tests
4f45ea1f73 Merge #19725: [RPC] Add connection type to getpeerinfo, improve logs
8aa3a4a498 Merge #20022: test: use explicit p2p objects where available
92e28fa8b2 test: remove unused constants in functional tests
0fcaf73199 test: use explicit p2p objects where available
8a4dcda414 doc: Added default signet config for linearize script
b3972bca9f doc: Mention signet in -help output
78f912c901 Merge #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property
af57766182 Fix misleading error message: Clean stack rule
2ea62cae48 Improve docs about feeler connections
a0b2e5cb6a doc: Add release notes to support multiple interfaces
b1c3f180ec doc: Adjust ZMQ usage to support multiple interfaces
347c94f551 zmq: Add support to listen on multiple interfaces
1b313cacc9 Merge #19927: validation: Reduce direct g_chainman usage
43305e9810 Merge #19868: build: Fix target name
5e14fafb31 Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
9b4fa0af40 net: Print error message if -proxy is specified without arguments (instead of continuing without proxy server)
8235dca621 Merge #19979: Replace LockAssertion with AssertLockHeld, remove LockAssertion
9e217f5a6f Merge #19572: ZMQ: Create "sequence" notifier, enabling client-side mempool tracking
8219893825 Merge #19993: refactor: Signet fixups
deb52711a1 Remove header checks out of net_processing
52d4ae46ab Give V1TransportDeserializer CChainParams& member
5bceef6b12 Change CMessageHeader Constructor
1ca20c1af8 Add doxygen comment for ReceiveMsgBytes
890b1d7c2b Move checksum check from net_processing to net
2716647ebf Give V1TransportDeserializer an m_node_id member
b1291b2e8f Merge #19963: Clarify blocksonly whitelistforcerelay test
c7eb85d005 Merge #19959: build: patch qt libpng to fix powerpc build
facaf9e61f doc: Document signet BIP
faf0a26711 doc: Update comments for new chain settings (-signet and -chain=signet)
fae0548686 fuzz: Remove needless guard
77771a03df refactor: Remove SignetTxs::m_valid and use optional instead
fa2ad5dae1 test: Run signet test even when wallet was not compiled
fa14f57fbc Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
759d94e70f Update zmq notification documentation and sample consumer
68c3c7e1bd Add functional tests for zmq sequence topic and mempool sequence logic
e76fc2b84d Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
1b615e61bf zmq test: Actually make reorg occur
d692d192cd Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)
a512925e19 [doc] Release notes
50f94b34a3 [rpc] Deprecate getpeerinfo addnode field
df091b9b50 [refactor] Rename test file to allow any getpeerinfo deprecations.
395acfa83a [rpc] Add connection type to getpeerinfo RPC, update tests
49c10a9ca4 [log] Add connection type to log statement
77376034d4 Merge #17785: p2p: Unify Send and Receive protocol versions
8c5f68118c Merge #18267: BIP-325: Signet [consensus]
c0c409dcd3 Merge #19697: Improvements on ADDR caching
72a1d5c6f3 validation: Remove review-only comments + assertions
3756853b15 docs: Move FindFilesToPrune{,Manual} doxygen comment
485899a93c style: Make FindFilesToPrune{,Manual} match style guide
3f5b5f3f6d validation: Move FindFilesToPrune{,Manual} to BlockManager
e15344889a Clarify blocksonly whitelistforcerelay test
7be6ff6187 net: recognize TORv3/I2P/CJDNS networks
f22d6a1142 log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)"
b99a1633b2 Merge #19781: test: add parameterized constructor for msg_sendcmpct()
38fd1bdcd4 Merge #18949: doc: Add CODEOWNERS file to automatically nominate PR reviewers
0bd1184adf Remove unused LockAssertion struct
ab2a44297f Replace LockAssertion with a proper thread safety annotations
73f71e1996 refactor: Use explicit function type instead of template
831b0ecea9 Merge #13686: ZMQ: Small cleanups in the ZMQ code
83b23848f7 Merge #18790: gui: Improve thread naming
c30f79d418 Merge #19940: rpc: Return fee and vsize from testmempoolaccept
967be53aee Merge #19971: test: create default wallet in extended tests
a5f5374b43 test: create default wallet in extended tests
0d9d2a1f7c Only update the updateSmartFeeLabel once in sync
8258c4c007 test: some sanity checks for consensus logic
e47ad375bf test: basic signet tests
4c189abdc4 test: add small signet fuzzer
ec9b25d046 test: signet network selection tests
3efe298dcc signet: hard-coded parameters for Signet Global Network VI (2020-09-07)
c7898bca4e qt: update QT to support signet network
a8de47a1c9 consensus: add signet validation
e8990f1214 add signet chain and accompanying parameters
652c45fdbb Merge #15454: Remove the automatic creation and loading of the default wallet
e0d73573a3 net: CNetAddr: add support to (un)serialize as ADDRv2
f7b331ea85 rpc: add brackets to ConstructTransaction
d813d26f06 [rpc] send: various touch-ups
0fc1c685e1 [rpc] send: fix parsing replaceable option
efc9b85e6f Mark send RPC experimental
fe42411b4b test: move HasReason so it can be reused
7a89f2e6c5 build: Fix target name
be3af4f310 Merge #19934: tests: Add fuzzing harness for Keccak and SHA3_256
a518b1c26b Merge #19936: Test: batch rpc with params
23c35bf005 [test] add get_vsize util for more programmatic testing
2233a93a10 [rpc] Return fee and vsize from testmempoolaccept
1c4f59728c Merge #19879: [p2p] miscellaneous wtxid followups
f8d4975ab3 validation: Move PruneOneBlockFile to BlockManager
74f73c783d validation: Pass in chainman to UnloadBlockIndex
f07fb5a55e build: patch qt libpng to fix powerpc build
62e3eb9888 Merge #19241: help: Generate checkpoint height from chainparams
48a9968e50 Merge #19558: build: split pthread flags out of ldflags and dont use when building libconsensus
6fe2ef2acb scripted-diff: Rename SendMessage to SendZmqMessage.
a33651866c Merge #19643: Add -netinfo peer connections dashboard
5d5e335f96 Merge #19903: Update build-openbsd.md with GUI support
ffaac6e614 Merge #16378: The ultimate send RPC
4668ded6d6 validation: Move ~CMainCleanup logic to ~BlockManager
a3abeec33a policy/fees: remove a floating-point division by zero
c36869bbf6 policy/fees: unify some duplicated for loops
569d92a4d2 policy/fees: small readability improvements
5b8cb35621 policy/fee: remove requireGreater parameter in EstimateMedianVal()
dba8196b44 policy/fees: correct decay explanation comments
fc9278d162 build: AX_PTHREAD serial 27
15c27c4441 build: split PTHREAD_* flags out of AM_LDFLAGS
68e3e22944 scripted-diff: add FUZZ_SUITE_LDFLAGS_COMMON
06dbbe76dd Merge #19931: Change CSipHasher's count variable to uint8_t
afecde8046 build: add PTHREAD_LIBS to LDFLAGS configure output
ba4b3fbcf2 Merge #19944: Update secp256k1 subtree (including BIP340 support)
e1fdd2963b Test batch rpc with params
be375b2206 Merge #19919: bugfix: make LoadWallet assigns status always
d438d609cd QA: Use GBT to get block versions correct
1df2cd1c8f QA: blocktools: Accept block template to create_block
b9c1a76481 Squashed 'src/secp256k1/' changes from 2ed54da18a..8ab24e8dad
894fb33f4c Update src/secp256k1 subtree to upstream libsecp256k1
f2d9934381 Merge #19922: test: Run rpc_txoutproof.py even with wallet disabled
d2bb681f96 util: move HasPrefix() so it can be reused
9366a73d69 Merge #19916: build: allow user to specify DIR_FUZZ_SEED_CORPUS for cov_fuzz
dffefda21d Merge #19870: doc: update PyZMQ install instructions, fix zmq_sub.py file permissions
812037cb80 Change CSipHasher's count variable to uint8_t
fc7f84a9ca tests: Add fuzzing harness for Keccak and SHA3_256
10d61505fe [test] remove confusing p2p property
549d30faf0 scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx
7a0de46aea [doc] sample code for test framework p2p objects
a47e596486 Merge #19841: Implement Keccak and SHA3_256
784f757994 [refactor] clarify tests by referencing p2p objects directly
d11020019a Add OpenBSD instructions for building the Qt GUI
d76925478e [doc] Clarify semantic of peer's m_protect w.r.t to outbound eviction logics
92326d8976 [rpc] add send method
404682b7cd add signet basic support (signet.cpp)
a2147d7dad validation: move GetWitnessCommitmentIndex to consensus/validation
62dba9628d log: print unexpected version warning in validation log category
8b39a87558 bugfix: make LoadWallet assigns status always
faf251d854 test: gettxoutproof duplicate txid
faf5eb45c4 test: Test empty array in gettxoutproof
fa56e866e8 test: Run rpc_txoutproof.py even with wallet disabled
faba790bd4 test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend
fa65a11d0c test: bugfix: Actually pick largest utxo
564e1ab0f3 Merge #19800: test: Mockwallet
d26f0648f1 Tell users how to load or create a wallet when no wallet is loaded
1bee1e6269 Do not create default wallet
4f229d8904 Merge #19914: refactor: Do not pass chain params to CheckForStaleTipAndEvictPeers twice
fb3bacce69 .gitignore: ignore qa-assets/ folder
a9f201439a build: use DIR_FUZZ_SEED_CORPUS if specified for cov_fuzz target
fa7e407b50 Do not pass chain params to CheckForStaleTipAndEvictPeers twice
001343f4bc ProcessOrphanTx: Move AddToCompactExtraTransactions call into ProcessOrphanTx
4fce726bd1 ProcessOrphanTx: Remove aliases
e07c5d9423 ProcessOrphanTx: Remove outdated commented
4763b51bca ProcessOrphanTx: remove useless setMisbehaving set
55c79a9cef ProcessOrphanTx: remove useless done variable
6e8dd99ef1 [net processing] Add doxygen comments for orphan data and function
2c2a1445dc [rpc] add snake case aliases for transaction methods
1bc8d0fd59 [rpc] walletcreatefundedpsbt: allow inputs to be null
ddefb5c0b7 p2p: Use the greatest common version in peer logic
e084d45562 p2p: Remove SetCommonVersion() from VERACK handler
8d2026796a refactor: Rename local variable nSendVersion
e9a6d8b13b p2p: Unify Send and Receive protocol versions
147d50d63e Merge #19791: [net processing] Move Misbehaving() to PeerManager
ac71fe936d [doc] Clarify scope of eviction protection of outbound block-relay peers
fa188c9c59 test: Use MiniWalet in p2p_feefilter
6954156b40 qt: Fix visual quality of text in QR image
bb6a32ce99 [net processing] Move Misbehaving() to PeerManager
aa114b1c9b [net_processing] Move SendBlockTransactions into PeerManager
3115e00f75 [net processing] Move MaybePunishPeerForTx to PeerManager
e662e2d42a [net processing] Move ProcessOrphanTx to PeerManager
b70cd890e3 [net processing] Move MaybePunishNodeForBlock into PeerManager
d7778351bf [net processing] Move ProcessHeadersMessage to PeerManager
64f6162651 [whitespace] tidy up indentation after scripted diff
58bd369b0d scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager
2297b26b3c [net_processing] Pass chainparams to PeerLogicValidation constructor
824bbd1ffb [move only] Collect all private members of PeerLogicValidation together
2583966130 Merge #19478: Remove CTxMempool::mapLinks data structure member
a3ffb6ebeb Replace zmqconfig.h by a simple zmqutil.
7f2ad1b9ac Use std::unique_ptr for CZMQNotifierFactory.
b93b9d5456 Simplify and fix notifier removal on error.
e15b1cfc31 Various cleanups in zmqnotificationinterface.
07087051af Merge #19556: Remove mempool global
78cb45d722 Merge #19738: wallet: Avoid multiple BerkeleyBatch in DelAddressBook
ab654c7d58 Unroll Keccak-f implementation
3f01ddb01b Add SHA3 benchmark
2ac8bf9583 Implement keccak-f[1600] and SHA3-256
56d47e19ed Merge #19619: Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp
af8135e369 Merge #19897: Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED
637d8bce74 Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED
68d1f1698f Merge #19890: refactor: remove unused header <arpa/inet.h> in protocol.cpp
c91f955f44 Merge #19887: test: Fix flaky wallet_basic test
abac436760 wallet: Avoid multiple BerkeleyBatch in DelAddressBook
0368931702 Merge #19881: ci: Double tsan CPU and Memory to avoid global timeout
2f79e9d002 refactor: remove unused header <arpa/inet.h> in protocol.cpp
56b018ca7f test: Fix flaky wallet_basic test
fafb381af8 Remove mempool global
fa0359c5b3 Remove mempool global from p2p
eeee1104d7 Remove mempool global from init
3ba25e3bdd Merge #19848: Remove mempool global from interfaces
416efcb7ab Merge #19728: Increase the ip address relay branching factor for unreachable networks
fa8e148714 ci: Double tsan CPU and Memory to avoid global timeout
81a19e7253 Merge #19852: refactor: Avoid duplicate map lookup in ScriptToAsmStr
fa9ee52556 doc: Add doxygen comment to IsRBFOptIn
faef4fc9b4 Remove mempool global from interfaces
fa831684e5 refactor: Add IsRBFOptInEmptyMempool
df75e9f3ee Merge #19878: rawtransaction: fix argument in combinerawtransaction help message
a8a64acaf3 [BroadcastTransaction] Remove unsafe move operator
125c038126 [p2p] Remove dead code
fc66d0a65c [p2p] Check for nullptr before dereferencing pointer
cb79b9dbf4 [mempool] Revert unbroadcast set to tracking just txid
4294e70690 rawtransaction: fix argument in combinerawtransaction help message
296be8f58e Get rid of unused functions CTxMemPool::GetMemPoolChildren, CTxMemPool::GetMemPoolParents
46d955d196 Remove mapLinks in favor of entry inlined structs with iterator type erasure
062e6699c4 script: fix zmq_sub.py file permissions
36f8e0cce7 doc: update PyZMQ installation instructions, ZeroMQ link
23d3ae7acc Merge #19405: rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo`
99a8eb6051 Merge #19854: Avoid locking CTxMemPool::cs recursively in simple cases
ac2ff4fb1e refactor: Avoid duplicate map lookup in ScriptToAsmStr
a0a422c34c Merge #19754: wallet, gui: Reload previously loaded wallets on startup
7bf6dfbb48 wallet: Remove path checking code from bitcoin-wallet tool
77d5bb72b8 wallet: Remove path checking code from createwallet RPC
a987438e9d wallet: Remove path checking code from loadwallet RPC
8b5e7297c0 refactor: Pass wallet database into CWallet::Create
3c815cfe54 wallet: Remove Verify and IsLoaded methods
0d94e60625 refactor: Use DatabaseStatus and DatabaseOptions types
b5b414151a wallet: Add MakeDatabase function
288b4ffb6b Remove WalletLocation class
825fcae484 [tests] Replace bytes literals with hex literals
64eca45100 [tests] Fix pep8 style violations in address.py
b230f8b3f3 [tests] Correct docstring for address.py
ea70e6a2ca [tests] Tidy up imports in address.py
7f639df0b8 [tests] Remove unused optional verify_checksum parameter
011e784f74 [tests] Rename segwit encode and decode functions
e4557133f5 [tests] Move bech32 unit tests to test framework
bd60a9a8ed Merge #19818: p2p: change `CInv::type` from `int` to `uint32_t`, fix UBSan warning
69a13eb246 Merge #19670: Protect localhost and block-relay-only peers from eviction
4053de04e2 Merge #19859: qa: Fixes failing functional test by changing version
620ac8c475 Merge #19724: [net] Cleanup connection types- followups
68f0ab26bc Merge #19805: wallet: Avoid deserializing unused records when salvaging
136fe4c5e9 Merge #19816: test: Rename wait until helper to wait_until_helper
9876ab8c74 Merge #19844: remove usage of boost::bind
2d4574aad8 Merge #19861: build: add /usr/local/ to LCOV_FILTER_PATTERN for macOS builds
eb1c5d090f [doc] Follow developer notes, add comment about missing default.
d5a57cef62 [doc] Describe connection types in more depth.
4829b6fcc6 [refactor] Simplify connection type logic in ThreadOpenConnections
1e563aed78 [refactor] Simplify check for block-relay-only connection.
da3a0be61b [test] Add explicit tests that connection types get set correctly
1d74fc7df6 [trivial] Small style updates
ff6b9081ad [doc] Explain address handling logic in process messages
dff16b184b [refactor] Restructure logic to check for addr relay.
a6ab1e81f9 [net] Remove unnecessary default args on OpenNetworkConnection
8d6ff46f55 scripted-diff: Rename `OUTBOUND` ConnectionType to `OUTBOUND_FULL_RELAY`
9bdde3c802 build: add /usr/local/ to LCOV_FILTER_PATTERN for macOS builds
bf1f913c44 cli -netinfo: display multiple levels of details
752e6ad533 Protect localhost and block-relay-only peers from eviction
c157a50694 Merge #19840: Avoid callback when -blocknotify is empty
8845b38b59 Merge #19685: depends: CMake invocation cleanup
c17a003758 Merge #19857: net: improve nLastBlockTime and nLastTXTime documentation
6de9429087 qa: Changes v0.17.1 to v0.17.2
505b39e72b Merge #19610: p2p: refactor AlreadyHave(), CInv::type, INV/TX processing
0d04784af1 Refactor the functional test
83ad65f31b Address nits in ADDR caching
3a3e21dafb Merge #14687: zmq: enable tcp keepalive
f1ee37319a wallet: Reload previously loaded wallets on GUI startup
d780293e1e net: improve nLastBlockTime and nLastTXTime documentation
a06eb03ded doc: Add comments and additional reviewers to CODEOWNERS file
48c1083632 Merge #19105: Add Muhash3072 implementation in Python
8de51d1513 doc: el…
We just updated the subtree to use branch `0.21.2` using:
git subtree pull --prefix='depend/bitcoin' \
[email protected]:bitcoin/bitcoin.git v0.21.2 \
--squash
This adds two patches to the tree but these two patches do not build.
This patch fixes the build, I could not think of a way to keep the code
building on all commits.
Includes changes to the build script by Jake and update to the C++
toolchain suggested by Richard.
Uses the new version format, increasing the Bitocoin Core version as is
applicable and also bumping the minor version of this lib.
Co-developed-by: Jake Rawsthorne <[email protected]>
Co-developed-by: Richard Ulrich <[email protected]>
We just upgraded the Bitcoin Core subtree to v0.21.2, bump our version number to reflect this. Add changelog notes, ready for release.
tcharding
force-pushed
the
bitcoin-core-0.21.2
branch
from
7870b8d to
1fd66da
Compare
3 tasks
|
hmmm, the clippy fail here uncovered a bug in CI, we are not testing features. (clippy is running with |
As we do in `rust-secp256k1` we can create type aliases for C integer types instead of depending on `libc`. Create type aliases (copied from `rust-secp256k1`) and remove libc dependency. Please note, this crate is copyright'ed to Tamas using Apache, but for this new file we use CC license since I copied it from `rust-secp256k1` (although its only a few trivial lines). Probably being overly paranoid but wanted to flag it.
9b3496a Remove libc dependency (Tobin C. Harding) Pull request description: As we do in `rust-secp256k1` we can create type aliases for C integer types instead of depending on `libc`. Create type aliases (copied from `rust-secp256k1`) and remove libc dependency. Please note, this crate is copyright'ed to Tamas using Apache, but for this new file we use CC license since I copied it from `rust-secp256k1` (although its only a few trivial lines). Probably being overly paranoid but wanted to flag it. Fixes: rust-bitcoin#57 ACKs for top commit: apoelstra: ACK 9b3496a Tree-SHA512: 18fdb35d905060cf257e7431ccc082b3444393ee03a239d1d85a4d2e99c3bc3d4709bb2f0f733f6b8ad2c15707e947b75bd590a26c0d2b40ed1b30c5b3743654
The SPDX license list and SPDX license identifiers are a standard terse way to add license information to source code files. Remove the licence information and replace it with an SPDX ID (see https://spdx.dev/ids/#how).
c59e660 Introduce SPDX identifiers (Tobin C. Harding) Pull request description: The SPDX license list and SPDX license identifiers are a standard terse way to add license information to source code files. Remove the licence information and replace it with an SPDX ID (see https://spdx.dev/ids/#how). This was done in `rust-bitcoin` in PR: rust-bitcoin/rust-bitcoin#1076 ACKs for top commit: apoelstra: ACK c59e660 Tree-SHA512: 8dc445aff88dde9848918baed231646319a3e2da5c4bb456bbaea36e791b69a441b1019384ca7906989531a776c83882d17b6ea5914aacb4084be2f3c1986acb
The `required_version` config option adds very little value and is annoying to maintain because it has to be updated everytime a new version of `clippy` drops.
The option `fn_args_layout` has been deprecated in favour of `fn_params_layout`.
Clippy emits warnings of form: warning: casting to the same type is unnecessary Remove the unnecessary casts.
Error types need only derive `Debug`.
Improve rustdocs on `Error` by doing: - Document the reason we use unconventional enum variant identifiers. - Use a live link to `shared-libraries.md` in the Bitcoin Core repo - Use angle brackets on link
Add a quote from the `shared-libraries.md` file in Bitcoin Core that describes `libbitcoinconsensus`.
We are currently explicitly setting fields in the manifest `[lib]` section to their defaults, this is unnecessary.
ddd61f0 Remove unnecessary section from manifest (Tobin C. Harding) 7a4fbbf Improve the library level rustdoc (Tobin C. Harding) 1b464ae Improve rustdocs on error type (Tobin C. Harding) 2bbfc28 Only derive Debug for error type (Tobin C. Harding) 07f80cc Remove unnecessary cast (Tobin C. Harding) 4922750 rustfmt: Use fn_params_layout (Tobin C. Harding) 1faa8f0 rustfmt: Remove required_version (Tobin C. Harding) Pull request description: Go through rust-bitcoin/rust-bitcoin#1649 and attempt to verify that we have every t crossed and i dotted. With this PR I believe we could consider stabilising the `bitcoinconsensus` crate, am I wrong? Are there any considerations re the semver number we are using or the fact that we are wrapping 0.20.0 Bitcoin Core? ACKs for top commit: apoelstra: ACK ddd61f0 Tree-SHA512: 794c7bc2c06e8418470b8b591bfb2d48e059bd3599793ee150bdc96918504a0cd7702f6e87fa878ef63d2f10fd917fc38d3f57ed1a52a92af31767efe3fb9ecf
As we are doing ecosystem wide; bump the MSRV to Rust 1.48.0
f0783dc Bump MSRV to Rust 1.48.0 (Tobin C. Harding) Pull request description: As we are doing ecosystem wide; bump the MSRV to Rust 1.48.0 ACKs for top commit: stevenroose: ACK f0783dc apoelstra: ACK f0783dc Tree-SHA512: 6e9147d3c9faf4479e6667733bcfcceed505005bc5a1f7e302bd2296fff9f5a65188dc23b43532966bb0456b8c85d41f7132637f93cd47aed3018de193b9e5c3
|
Were the C/C++ build issues ever resolved with this? Following up on this because the next core release will contain support for Taproot verification which is a nice addition (bitcoin/bitcoin#28539) so it would be good to resolve any remaining build issues |
Closed
We have moved away from using this comment in the rest of the `rust-bitcoin` org repos, do so here also.
The error path is a little hard to read, Core sets the mutable err pointer and return zero from `bitcoinconsensus_verify_script_with_amount` if an error occurred. Add a code comment stating as much.
We use github actions for CI now, we no longer need the old travis config file.
In preparation for release bump the version and add a changelog entry.
…' into bitcoin-core-0.21.2
|
Now on top of #67 |
|
Superseded by #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This breaks the "external-secp" feature. I am unable to work it out at the current time. @elichai I see in commit
3e0009474bcthat you added the feature, should I be trying to link in an external static lib? I tried passing one into the build script using an env var and calling `consensus_config.include() but to no avail.Currently we are vendoring the source code from Bitcoin Core
v0.20.1.Update the subtree to use branch
0.21.2using:Includes changes to the build script by @jrawsthorne and update to the C++ toolchain suggested by @ulrichard in #31.
Note: The subtree update produces two commits that do not build. The patch to fix the build as done separately.
Close: #31