Fix up verify v17
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we wrote the `verify` crate these docs are stale. `verify` was inspired by this exact comment.
Currently the `verify` command relies on incomplete integration tests including `todo!` on the same line as the test name - this is sub-optimal but while its like that at least follow the rules.
Clippy warns for unused imports; add a feature gate.
Fix the integration test for `recievedbyaddress`. Requires fixing the client method implementation also because I forgot to pass in the address - duh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of problems highlighted when one runs
verify v17- fix them. Includes fix the client and integration test around thegetreceivedbyaddressesmethod.