Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of supported minor versions #27

Merged

Conversation

tcharding
Copy link
Member

We support Core back to v0.17.1 and currently explicitly test all minor versions back to v22 - this is probably an overkill and is only going to increase as Core progresses. Instead lets just test all minor versions of the last three releases and then the latest minor version for older releases.

This has the benefit of reducing the number of CI jobs.

@tcharding tcharding changed the title Reduce number of supported minor version Reduce number of supported minor versions Dec 6, 2024
@tcharding tcharding force-pushed the 12-07-reduce-tested-versions branch 2 times, most recently from afde282 to c8941ab Compare December 6, 2024 21:50
We support Core back to v0.17.1 and currently explicitly test all minor
versions back to v22 - this is probably an overkill and is only going to
increase as Core progresses. Instead lets just test all minor versions
of the last three releases and then the latest minor version for older
releases.

This has the benefit of reducing the number of CI jobs.
@tcharding tcharding force-pushed the 12-07-reduce-tested-versions branch from c8941ab to 93a3a99 Compare December 6, 2024 22:09
@tcharding
Copy link
Member Author

I'm going to merge this but if you get a chance @apoelstra could you post-merge concept ack this please. I can then revert if you think it was not a good idea. Thanks man.

@tcharding tcharding merged commit 0d1a18b into rust-bitcoin:master Dec 6, 2024
26 checks passed
@tcharding tcharding deleted the 12-07-reduce-tested-versions branch December 6, 2024 22:23
@apoelstra
Copy link
Member

concept ACK. Yeah, let's just support the latest minor version of each major version.

@tcharding
Copy link
Member Author

Even for the last three major releases? Currently we do all minor versions for the last 3 major versions and just the latest minor version for all older major versions.

@apoelstra
Copy link
Member

Hmm, this raises an interesting question -- removing old releases is a breaking change.

So maybe our policy should be "every time there's a major rev we delete all old minor releases".

But yes, probably we should have all the minor releases for the most recent major version. As for older ones, I leave it up to you to decide whether it's worth the maintenance burden.

@tcharding
Copy link
Member Author

So maybe our policy should be "every time there's a major rev we delete all old minor releases".

The only real burden is more CI jobs so I rekon its ok to keep all minor versions for the last 3 major releases. I seem to remember reading somewhere that the last 3 major releases were more actively maintained - or have I just imagined that?

@apoelstra
Copy link
Member

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants