access modifier changed

rushisangani · Jan 17, 2024 · 4008c0e · 4008c0e
1 parent 44c4bdf
commit 4008c0e
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 32 deletions.
diff --git a/Sources/NetworkKit/APIRequestHandler.swift b/Sources/NetworkKit/APIRequestHandler.swift
@@ -20,7 +20,7 @@ public protocol RequestHandler {
 public struct APIRequestHandler: RequestHandler {
     let session: URLSession
 
-    init(session: URLSession = .shared) {
+    public init(session: URLSession = .shared) {
         self.session = session
     }
 

diff --git a/Sources/NetworkKit/APIResponseHandler.swift b/Sources/NetworkKit/APIResponseHandler.swift
@@ -10,20 +10,20 @@ import Combine
 
 // MARK: - ResponseHandler
 
-protocol ResponseHandler {
+public protocol ResponseHandler {
     func getResponse<T: Decodable>(from response: Data) throws -> T
 }
 
 // MARK: - APIResponseHandler
 
-struct APIResponseHandler: ResponseHandler {
+public struct APIResponseHandler: ResponseHandler {
     let decoder: JSONDecoder
 
-    init(decoder: JSONDecoder = JSONDecoder()) {
+    public init(decoder: JSONDecoder = JSONDecoder()) {
         self.decoder = decoder
     }
 
-    func getResponse<T: Decodable>(from data: Data) throws -> T {
+    public func getResponse<T: Decodable>(from data: Data) throws -> T {
         do {
             return try decoder.decode(T.self, from: data)
         } catch {

diff --git a/...workKitTests/Utils/Bundle+Extension.swift → Sources/NetworkKit/Bundle+Extension.swift b/...workKitTests/Utils/Bundle+Extension.swift → Sources/NetworkKit/Bundle+Extension.swift
@@ -9,23 +9,23 @@ import Foundation
 
 extension Bundle {
 
-    func jsonFilePath(forName fileName: String) -> String {
+    public func jsonFilePath(forName fileName: String) -> String {
         path(forResource: fileName, ofType: "json") ?? ""
     }
 
-    func fileData(forResource resource: String) throws -> Data {
+    public func fileData(forResource resource: String) throws -> Data {
         let filePath = jsonFilePath(forName: resource)
 
         var url: URL
-        if #available(iOS 16.0, *) {
+        if #available(iOS 16.0, watchOS 9.0, macOS 13.0, *) {
             url = URL(filePath: filePath)
         } else {
             url = URL(fileURLWithPath: filePath)
         }
         return try Data(contentsOf: url)
     }
 
-    func decodableObject<T: Decodable>(forResource resource: String, type: T.Type) throws -> T {
+    public func decodableObject<T: Decodable>(forResource resource: String, type: T.Type) throws -> T {
         let data = try fileData(forResource: resource)
         return try JSONDecoder().decode(T.self, from: data)
     }

diff --git a/...tworkKitTests/Mocks/MockURLProtocol.swift → Sources/NetworkKit/MockURLProtocol.swift b/...tworkKitTests/Mocks/MockURLProtocol.swift → Sources/NetworkKit/MockURLProtocol.swift
@@ -7,19 +7,19 @@
 
 import Foundation
 
-class MockURLProtocol: URLProtocol {
-    static var error: Error?
-    static var requestHandler: ((URLRequest) throws -> (Data, HTTPURLResponse))?
+public final class MockURLProtocol: URLProtocol {
+    public static var error: Error?
+    public static var requestHandler: ((URLRequest) throws -> (Data, HTTPURLResponse))?
 
-    override class func canInit(with request: URLRequest) -> Bool {
+    public override class func canInit(with request: URLRequest) -> Bool {
         true
     }
 
-    override class func canonicalRequest(for request: URLRequest) -> URLRequest {
+    public override class func canonicalRequest(for request: URLRequest) -> URLRequest {
         request
     }
 
-    override func startLoading() {
+    public override func startLoading() {
         if let error = MockURLProtocol.error {
             client?.urlProtocol(self, didFailWithError: error)
             return
@@ -40,13 +40,13 @@ class MockURLProtocol: URLProtocol {
         }
     }
 
-    override func stopLoading() {
+    public override func stopLoading() {
     }
 }
 
 extension URLSession {
 
-    static var mock: URLSession {
+    public static var mock: URLSession {
         let configuration: URLSessionConfiguration = .ephemeral
         configuration.protocolClasses = [MockURLProtocol.self]
         return URLSession(configuration: configuration)

diff --git a/Sources/NetworkKit/NetworkManager.swift b/Sources/NetworkKit/NetworkManager.swift
@@ -21,7 +21,7 @@ public final class NetworkManager: NetworkHandler {
     var requestHandler: RequestHandler
     var responseHandler: ResponseHandler
 
-    init(requestHandler: RequestHandler = APIRequestHandler(),
+    public init(requestHandler: RequestHandler = APIRequestHandler(),
          responseHandler: ResponseHandler = APIResponseHandler()
     ) {
         self.requestHandler = requestHandler

diff --git a/Sources/NetworkKit/Request.swift b/Sources/NetworkKit/Request.swift
@@ -19,19 +19,19 @@ public protocol Request {
 }
 
 extension Request {
-    var scheme: String {
+    public var scheme: String {
         "https"
     }
 
-    var headers: [String: String] {
+    public var headers: [String: String] {
         [:]
     }
 
-    var params: [String: Any] {
+    public var params: [String: Any] {
         [:]
     }
 
-    var requestType: RequestType {
+    public var requestType: RequestType {
         .get
     }
 

diff --git a/Tests/NetworkKitTests/Mocks/MockRequest.swift b/Tests/NetworkKitTests/Mocks/MockRequest.swift
@@ -17,13 +17,3 @@ public struct MockCommentsRequest: Request {
         try! createURLRequest().url!
     }
 }
-
-public struct MockPostsRequest: Request {
-    public var scheme: String { "https" }
-    public var host: String { "jsonplaceholder.typicode.com" }
-    public var path: String { "/posts" }
-
-    var url: URL {
-        try! createURLRequest().url!
-    }
-}