Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the Broken link of Language/general_web_fundamental/hitesh choudhary youtube #2513

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

akashchoudhary436
Copy link
Contributor

@akashchoudhary436 akashchoudhary436 commented Oct 1, 2024

-fix bug
The Broken link of the Language/general_web_fundamental/hitesh choudhary youtube is been fixed
Changes made is
Before fix link is : https://www.youtube.com/@HiteshChoudharydotcom
After Link fix : https://www.youtube.com/@HiteshCodeLab
Screenshot 2024-10-02 004529
Screenshot 2024-10-02 004516

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:06pm

@github-actions github-actions bot added bug Something isn't working chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature labels Oct 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@rupali-codes
Copy link
Owner

@akashchoudhary436 why have you closed it?

@akashchoudhary436
Copy link
Contributor Author

Sorry its not been assign
I again reopen the PR

@rajneesh-18
Copy link
Collaborator

@akashchoudhary436 there is 3 failing checks. So, update your pr with all the changes.

@akashchoudhary436 akashchoudhary436 changed the title Fixed the Broken link of Language/general_web_fundamental/hitesh choudhary youtube -fix the Broken link of Language/general_web_fundamental/hitesh choudhary youtube Oct 2, 2024
@akashchoudhary436 akashchoudhary436 changed the title -fix the Broken link of Language/general_web_fundamental/hitesh choudhary youtube fix : the Broken link of Language/general_web_fundamental/hitesh choudhary youtube Oct 2, 2024
@akashchoudhary436 akashchoudhary436 changed the title fix : the Broken link of Language/general_web_fundamental/hitesh choudhary youtube fix: the Broken link of Language/general_web_fundamental/hitesh choudhary youtube Oct 2, 2024
@akashchoudhary436
Copy link
Contributor Author

@rupali-codes the link had been fixed kindly review it and merge the PR

@rupali-codes
Copy link
Owner

@rupali-codes the link had been fixed kindly review it and merge the PR

Is there any issue to be closed with this PR?

@akashchoudhary436
Copy link
Contributor Author

@rupali-codes No issue

@rupali-codes
Copy link
Owner

@akashchoudhary436 we are merging this PR for now, but please raise an issue before working/fixing anything.

@rupali-codes rupali-codes merged commit 916e161 into rupali-codes:main Oct 3, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants