Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links fixed #2342

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Links fixed #2342

merged 1 commit into from
Apr 20, 2024

Conversation

Mouh1b
Copy link
Contributor

@Mouh1b Mouh1b commented Apr 11, 2024

Fixes Issue

#2331

Changes proposed

changing two links that have weong pages or the page was not found

Screenshots

image
image

Note to reviewers

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024

@Mouh1b is attempting to deploy a commit to the Rupali Haldiya's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added bug Something isn't working chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature labels Apr 11, 2024
github-actions[bot]
github-actions bot reviewed Apr 11, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mouh1b, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal Anmol-Baranwal linked an issue Apr 12, 2024 that may be closed by this pull request
[BUG] <link gives 404 page not found > #2331
Closed
3 tasks
Anmol-Baranwal
Anmol-Baranwal approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

In the first link, it appears to be reviews of various insights. Anyway, the link works :)

rupali-codes
rupali-codes approved these changes Apr 20, 2024
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 3d5dbde into rupali-codes:main Apr 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rupali-codes rupali-codes rupali-codes approved these changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

@aftabrehan aftabrehan Awaiting requested review from aftabrehan

@CBID2 CBID2 Awaiting requested review from CBID2

Assignees

@Mouh1b Mouh1b

Labels
bug Something isn't working chore Might take time to finish goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) priority: medium Modifying an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] <link gives 404 page not found >
3 participants
@Mouh1b @Anmol-Baranwal @rupali-codes