Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2309 Fix favicon #2311

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

bottlewook
Copy link
Contributor

@bottlewook bottlewook commented Mar 18, 2024

Fixes Issue

Closes #2309

Changes proposed

Reflecting favicons

Screenshots

스크린샷 2024-03-18 오후 10 35 06

Note to reviewers

Copy link

vercel bot commented Mar 18, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, bottlewook, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@github-actions github-actions bot added bug Something isn't working priority: medium Modifying an existing feature labels Mar 18, 2024
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 10:27am

rupali-codes
rupali-codes previously approved these changes Mar 18, 2024
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aftabrehan
aftabrehan previously approved these changes Mar 19, 2024
Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @bottlewook 💪 🚀 💯

It just needs minor adjustment, and then we're good to go 🚀

public/favicon/site.webmanifest Outdated Show resolved Hide resolved
@aftabrehan aftabrehan dismissed stale reviews from rupali-codes and themself via 78320b3 March 19, 2024 09:29
@aftabrehan
Copy link
Collaborator

@Anmol-Baranwal, @CBID2 Please, help to review and merge the PR.

@bottlewook
Copy link
Contributor Author

@rupali-codes @aftabrehan Invite me back next time! I'm having so much fun contributing.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupali-codes
Copy link
Owner

@rupali-codes @aftabrehan Invite me back next time! I'm having so much fun contributing.

Sure!!, Please keep an eye on the open issues with up for grabs label

@rupali-codes rupali-codes merged commit 6c1b0e0 into rupali-codes:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Favicon is not showing
4 participants