fix : Handled the async visuals while switching themes in sub-categories pages (#2294) #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
github-actions
bot
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Anmol-Baranwal
previously approved these changes
Mar 16, 2024
CBID2
reviewed
Mar 16, 2024
aftabrehan
requested changes
Mar 17, 2024
Co-authored-by: Aftab Rehan <[email protected]>
|
As per the suggestion, I have removed transition classes, and all things are working fine. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@Sahil-106 it looks great, but can we also add some smooth transition here?
@rupali-codes |
aftabrehan
reviewed
Mar 17, 2024
aftabrehan
approved these changes
Mar 18, 2024
|
@rupali-codes, can you please help to review and merge the PR? |
Anmol-Baranwal
approved these changes
Mar 19, 2024
|
@rupali-codes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #2294
Changes proposed
By setting the duration property to 0, I have removed the transition effect altogether. This means that when switching between themes, there won't be any animation delay in the body of sub-categories pages in applying the theme change. It will happen instantly.
Screenshots
sub-categories.2.mp4
Note to reviewers
As a newcomer to open source, I am excited to be part of such a vibrant community and to have the opportunity to contribute to this project. I have carefully reviewed the changes and tested them to ensure they work as intended. However, as this is my first contribution, I welcome any feedback or suggestions you may have to improve the code. thank you!