Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS games subcategory under Frontend category. #2264

Merged

Conversation

JuanPabloDiaz
Copy link
Contributor

Fixes Issue

Closes #2258: Add CSS Games subcategory under Frontend

Changes proposed

  • Create a new subcategory called CSS Games under the frontend category.
  • Modify the CategoryDescriptions.ts file to include CSS Games.
  • Create a new file called css-games.json in the frontend database folder to include all the URLs related to CSS Games.
  • Modify the sitemap.xml file to include CSS Games.
  • Modify the index.ts file in the database folder to include CSS Games.
  • Modify the data.ts file in the database folder to include CSS Games.

Learn CSS Grid, Flex and more by Playing Games

Screenshots

cssGames

Note to reviewers

Copy link

vercel bot commented Feb 12, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Feb 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JuanPabloDiaz. Your Pull Request is off to a great start. I'm thinking it'd be best to call the subcategory games instead of separating them by language. It creates more cohesiveness.

database/frontend/css-games.json Show resolved Hide resolved
database/frontend/css-games.json Show resolved Hide resolved
database/frontend/css-games.json Show resolved Hide resolved
database/index.ts Show resolved Hide resolved
public/sitemap.xml Show resolved Hide resolved
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 why have you renamed to games? won't this be confusing for other people?

@Anmol-Baranwal
Copy link
Collaborator

@CBID2 why have you renamed to games? won't this be confusing for other people?

@rupali-codes Please deploy.

I second this, it can be games too but considering it is in frontend -> css games would be better because most of the game platforms are related to CSS.

@CBID2
Copy link
Collaborator

CBID2 commented Feb 12, 2024

@CBID2 why have you renamed to games? won't this be confusing for other people?

@rupali-codes Please deploy.

I second this, it can be games too but considering it is in frontend -> css games would be better because most of the game platforms are related to CSS.

Oh I see.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @JuanPabloDiaz. Looks good to me

@CBID2
Copy link
Collaborator

CBID2 commented Feb 12, 2024

@rupali-codes & @Anmol-Baranwal, I approved the PR.

@JuanPabloDiaz
Copy link
Contributor Author

NP, thank you!

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @JuanPabloDiaz 👍

@aftabrehan aftabrehan added the status: ready-to-merge Approved & its ready-to-merge label Feb 13, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 9:22am

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 797d62a into rupali-codes:main Feb 14, 2024
11 checks passed
@JuanPabloDiaz JuanPabloDiaz deleted the cssGames-juandiazContribution branch March 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSS Games subcategory under Frontend category
5 participants