-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS games subcategory under Frontend category. #2264
Add CSS games subcategory under Frontend category. #2264
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JuanPabloDiaz. Your Pull Request is off to a great start. I'm thinking it'd be best to call the subcategory games instead of separating them by language. It creates more cohesiveness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBID2 why have you renamed to games
? won't this be confusing for other people?
@rupali-codes Please deploy. I second this, it can be |
Oh I see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @JuanPabloDiaz. Looks good to me
@rupali-codes & @Anmol-Baranwal, I approved the PR. |
NP, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR, @JuanPabloDiaz 👍
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes Issue
Closes #2258: Add CSS Games subcategory under Frontend
Changes proposed
CategoryDescriptions.ts
file to include CSS Games.css-games.json
in the frontend database folder to include all the URLs related to CSS Games.sitemap.xml
file to include CSS Games.index.ts
file in the database folder to include CSS Games.data.ts
file in the database folder to include CSS Games.Learn CSS Grid, Flex and more by Playing Games
Screenshots
Note to reviewers