Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2071-Side pagination #2236

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

Raj100679
Copy link
Contributor

Fixes Issue #2231

Changes proposed

Screenshots

Note to reviewers

Copy link

vercel bot commented Jan 16, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Raj100679, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Raj100679
Copy link
Contributor Author

@CBID2 @rupali-codes @aftabrehan Done the requested changes, Can you check this

@Anmol-Baranwal
Copy link
Collaborator

Replacement of #2071.

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Please deploy this. We will review and merge it quickly.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:27am

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment is failing
image

@Raj100679
Copy link
Contributor Author

@rupali-codes I will look into it

@rupali-codes
Copy link
Owner

@rupali-codes I will look into it

you working on it..

@Raj100679
Copy link
Contributor Author

@rupali-codes Yeah, I dont know somewhing is breaking my code, I will raise a new pr or will try to fix this one

@aftabrehan
Copy link
Collaborator

aftabrehan commented Jan 20, 2024

@rupali-codes Yeah, I dont know somewhing is breaking my code, I will raise a new pr or will try to fix this one

@Raj100679, Let me know if you need any help.

@Raj100679
Copy link
Contributor Author

@rupali-codes @aftabrehan Can you check if it is deploying properly

@rupali-codes
Copy link
Owner

@rupali-codes @aftabrehan Can you check if it is deploying properly

Sure, thanks for the changes

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@rupali-codes I'm approving, but there are two navigation and on the last page, both are shown in single screen.

@rupali-codes rupali-codes merged commit 229077d into rupali-codes:main Jan 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants