-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: saved resources page #2211
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Vidip-Ghosh, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vidip-Ghosh. I went to the Saved section and it showed me this .
In sidebar component, I replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end, but I want to see what @Anmol-Baranwal & @aftabrehan thinks. You too @rupali-codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR, @Vidip-Ghosh 💪 🚀 💯
A few adjustments are required and then we're good to go 🚀
@aftabrehan In dev branch, I am getting this error due to which I am unable to debug. How can I solve? |
@aftabrehan In dev branch, I am getting this error due to which I am unable to debug. How can I solve? It seems this error is triggered by a missing dependency. Could you please try to run |
I ran but it shows up to date & still the same error.@aftabrehan In dev branch, I am getting this error due to which I am unable to debug. How can I solve? |
@Vidip-Ghosh, Please, run a clean build of your Next.js project. This involves deleting the
|
I was saying, it wasn't exactly the same as the interface design in figma. You need to do some styling changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vidip-Ghosh its looking too sticky, can you add a little space around the heading as in the design?
Yes I'll |
@rupali-codes I hope this much space is alright |
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
@aftabrehan @rupali-codes @CBID2
Please review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! 😎 Your turn @rupali-codes or @aftabrehan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
It just needs minor adjustments and then we're good to go 🚀
@rupali-codes, could you assist in authorizing the deployment? This way, we can review the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes Issue
Closes #2174
Changes proposed
I've started to work on Saved new resources page.
Its in
/saved
route.Screenshots
Note to reviewers