Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hugo link #1774

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat: Add Hugo link #1774

merged 4 commits into from
Oct 5, 2023

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Oct 3, 2023

Closes #1709

Changes proposed

Add link for Hugo framework website to the 'Other' category under a new subcategory named 'Other Tools' (URL: other/other-tools)

Screenshots

one

two

Note to reviewers

Hacktoberfest

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 2:07pm

@github-actions github-actions bot added quick-fix Shouldn't take much time to finish goal: new-feature New feature or request goal: new-link Addition of new links related contributions labels Oct 3, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, R055A, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 added the hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest label Oct 3, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @R055A! :) Just made some adjustments to the description. Other than that, you're off to a great start! :)

database/other/other-tools.json Outdated Show resolved Hide resolved
CBID2
CBID2 previously approved these changes Oct 4, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @R055A! :) @Anmol-Baranwal, it's your turn! :)

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2
Rather than creating a new subcategory, can't we add this in Dev Tools subcategory in

image

What do you think?

@CBID2
Copy link
Collaborator

CBID2 commented Oct 4, 2023

@CBID2

Rather than creating a new subcategory, can't we add this in Dev Tools subcategory in

image

What do you think?

I don't know @Anmol-Baranwal. My intention with technical writing subcategory is to create a hub of tools where people who have that role can find what they need, especially since they are not often spotlighted in conversations about roles to pursue in tech.

@Anmol-Baranwal
Copy link
Collaborator

I don't know @Anmol-Baranwal. My intention with technical writing subcategory is to create a hub of tools where people who have that role can find what they need, especially since they are not often spotlighted in conversations about roles to pursue in tech.

See the image below.
image

It is in Other/other tools not technical writing

@CBID2
Copy link
Collaborator

CBID2 commented Oct 4, 2023

I don't know @Anmol-Baranwal. My intention with technical writing subcategory is to create a hub of tools where people who have that role can find what they need, especially since they are not often spotlighted in conversations about roles to pursue in tech.

See the image below.

image

It is in Other/other tools not technical writing

Thanks for pointing that out @Anmol-Baranwal! :) I still want it in Technical Writing/Tools though.

@R055A
Copy link
Contributor Author

R055A commented Oct 4, 2023

I don't know @Anmol-Baranwal. My intention with technical writing subcategory is to create a hub of tools where people who have that role can find what they need, especially since they are not often spotlighted in conversations about roles to pursue in tech.

See the image below.
image
It is in Other/other tools not technical writing

Thanks for pointing that out @Anmol-Baranwal! :) I still want it in Technical Writing/Tools though.

Hi @CBID2 and @Anmol-Baranwal. Neither Dev Tools nor Technical Writing is included in the Issue #1709 requirements:

Site URL

https://gohugo.io/

Description of the above provided site

If you're looking for a framework to help you build your documentation site quickly, check out Hugo. It allows you to output your content in multiple formats, including JSON or AMP as well as provides shortcodes to simplify your Markdown files.

Category

Other

Sub Category

Tools

Checklist

* [x]  I have checked the existing issues

* [x]  I have read the [Contributing Guidelines](https://github.com/rupali-codes/LinksHub/blob/main/CONTRIBUTING.md)

* [ ]  I am willing to work on this issue (optional)

@CBID2
Copy link
Collaborator

CBID2 commented Oct 4, 2023

Yeah @R055A. When I raised this issue, that option was not in the issue for it. There's a PR that's going to address it soon. For now, just add it to that category.

@R055A
Copy link
Contributor Author

R055A commented Oct 5, 2023

Yeah @R055A. When I raised this issue, that option was not in the issue for it. There's a PR that's going to address it soon. For now, just add it to that category.

Hi @CBID2. Thank you for your prompt reply. Can you please confirm if you want the category for the Hugo link changed to either other/devtools or technical-writing/tools, or to remain other/other-tools

@CBID2
Copy link
Collaborator

CBID2 commented Oct 5, 2023

technical-writing/tools

technical-writing/tools @R055A

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R055A
Change the category of Hugo to Technical Writing/Technical Writing Tools and remove this subcategory Other Tools as mentioned in the image below.

Remove it from here:

image

and add it here:

image

@R055A
Copy link
Contributor Author

R055A commented Oct 5, 2023

@R055A Change the category of Hugo to Technical Writing/Technical Writing Tools and remove this subcategory Other Tools as mentioned in the image below.

Remove it from here:

image

and add it here:

image

Done:

one

two

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@R055A thanks for the changes.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @R055A

@CBID2 CBID2 merged commit 391156d into rupali-codes:main Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request goal: new-link Addition of new links related contributions hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Hugo
3 participants