Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Hacktoberfest in Outreach section #1717

Merged

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

Closes #1703

Note to reviewers

@CBID2
Please check the changes.

@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 7:20am

@github-actions github-actions bot added the quick-fix Shouldn't take much time to finish label Oct 1, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 added documentation Improvements or additions to documentation hacktoberfest hacktoberfest2023 labels Oct 1, 2023
@Anmol-Baranwal Anmol-Baranwal removed the hacktoberfest hacktoberfest2023 label Oct 1, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

Anmol-Baranwal commented Oct 1, 2023

@CBID2
We don't need to add labels, as topics for hacktoberfest is already added.

image

@CBID2
Copy link
Collaborator

CBID2 commented Oct 1, 2023

Apparently we do @Anmol-Baranwal, says so here: https://hacktoberfest.com/participation/#pr-mr-details

@Anmol-Baranwal
Copy link
Collaborator Author

Apparently we do @Anmol-Baranwal, says so here: https://hacktoberfest.com/participation/#pr-mr-details

We are on a mission to confuse each other. LOL!

See, here it is written OR.

image
image

We only need to add it later, I think.
image

Let me know if I'm wrong.

@CBID2
Copy link
Collaborator

CBID2 commented Oct 1, 2023

Apparently we do @Anmol-Baranwal, says so here: https://hacktoberfest.com/participation/#pr-mr-details

We are on a mission to confuse each other. LOL!

See, here it is written OR.

image
image

We only need to add it later, I think.
image

Let me know if I'm wrong.

Ohhh thanks

@rupali-codes
Copy link
Owner

@CBID2 & @Anmol-Baranwal please make sure to add hacktoberfest-accepted before merging any PR :)

@CBID2 CBID2 added the hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest label Oct 3, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Oct 3, 2023

Done and the queen has returned! :)

@CBID2
Copy link
Collaborator

CBID2 commented Oct 3, 2023

@CBID2 & @Anmol-Baranwal please make sure to add hacktoberfest-accepted before merging any PR :)

Will this be merged @rupali-codes?

@Anmol-Baranwal
Copy link
Collaborator Author

@CBID2 & @Anmol-Baranwal please make sure to add hacktoberfest-accepted before merging any PR :)

Okay, but it will show up anyway. Since, the topics have been included in the repo.

@Anmol-Baranwal
Copy link
Collaborator Author

image

preview

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 97fa20b into rupali-codes:main Oct 10, 2023
9 checks passed
@Anmol-Baranwal Anmol-Baranwal deleted the outreach_hacktoberfest branch October 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] <add Hacktoberfest logo to outreach section>
3 participants