Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: techncial writing category and Docsify #1701

Merged
merged 4 commits into from
Sep 30, 2023
Merged

add: techncial writing category and Docsify #1701

merged 4 commits into from
Sep 30, 2023

Conversation

CBID2
Copy link
Collaborator

@CBID2 CBID2 commented Sep 29, 2023 •
edited
Loading

Fixes Issue

Closes #1693
Closes #1692

Changes proposed

I added a technical writing category with a "tools" subcategory with a link to Docsify

Screenshots

Note to reviewers

It's still a WIP

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Sep 30, 2023 0:01am

@github-actions github-actions bot added quick-fix Shouldn't take much time to finish documentation Improvements or additions to documentation goal: new-category Addition of new categories related contributions labels Sep 29, 2023
github-actions[bot]
github-actions bot reviewed Sep 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, CBID2, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

As I said, I don't know what is the problem with category, I need to add one myself in order to understand where is the problem.

@rupali-codes will be able to help with this.

@rupali-codes rupali-codes marked this pull request as ready for review September 30, 2023 14:43
@rupali-codes
Copy link
Owner

@CBID2 & @Anmol-Baranwal please review once

@CBID2
Copy link
Collaborator Author

CBID2 commented Sep 30, 2023

@CBID2 & @Anmol-Baranwal please review once

@rupali-codes, can you post a screenshot please? It still says deployment failed on the mobile app.

@rupali-codes
Copy link
Owner

rupali-codes commented Sep 30, 2023 •
edited
Loading

@CBID2 & @Anmol-Baranwal please review once

@rupali-codes, can you post a screenshot please? It still says deployment failed on the mobile app.

Sure

image

@CBID2
Copy link
Collaborator Author

CBID2 commented Sep 30, 2023

Looks great! :)

CBID2
CBID2 commented Sep 30, 2023
View reviewed changes
Copy link
Collaborator Author

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupali-codes rupali-codes merged commit e503b70 into rupali-codes:main Sep 30, 2023
7 checks passed
@CBID2 CBID2 deleted the add-technical-writing-folder branch October 1, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rupali-codes rupali-codes rupali-codes approved these changes

@Anmol-Baranwal Anmol-Baranwal Awaiting requested review from Anmol-Baranwal Anmol-Baranwal is a code owner

Assignees

@CBID2 CBID2

Labels
documentation Improvements or additions to documentation goal: new-category Addition of new categories related contributions quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADD] <Technical Writing/Tools> [Add] <Docsify>
3 participants
@CBID2 @Anmol-Baranwal @rupali-codes