Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the fontSize for the small devices #1637

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

the-shivam-gupta
Copy link
Contributor

To optimise for smaller devices, the font size for the copyright section has been reduced.

Fixes Issue

#1625

Changes proposed

Screenshots

image

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 2:33pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the-shivam-gupta, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Co-authored-by: Rupali Haldiya <[email protected]>
Co-authored-by: Rupali Haldiya <[email protected]>
CBID2
CBID2 previously approved these changes Aug 30, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @the-shivam-gupta! I applied @rupali-codes' suggestions. Things look pretty good! :) LGTM! :)

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to align this in center. It would be helpful for everyone and make sure to give it some padding from both sides.

image

@the-shivam-gupta
Copy link
Contributor Author

@Anmol-Baranwal, I have made the changes please review it.

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Thanks for the changes.

@the-shivam-gupta
Copy link
Contributor Author

@rupali-codes, review it

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 merged commit 04a4387 into rupali-codes:main Sep 1, 2023
6 checks passed
@CBID2
Copy link
Collaborator

CBID2 commented Sep 1, 2023

Thanks for contributing @the-shivam-gupta! If you stay updated on LinksHub's progress, join our Discord! :) We loved to see more of your ideas! 😊

@the-shivam-gupta the-shivam-gupta deleted the reduce-font_size branch September 2, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants