Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OTHER-category at the end #1629

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: OTHER-category at the end #1629

merged 1 commit into from
Aug 25, 2023

Conversation

URVESH1121
Copy link
Contributor

Fixes Issue

Closes #1627

Screenshots

image

@vercel
Copy link

vercel bot commented Aug 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 8:14am

@github-actions github-actions bot added bug Something isn't working quick-fix Shouldn't take much time to finish goal: new-category Addition of new categories related contributions labels Aug 25, 2023
github-actions[bot]
github-actions bot reviewed Aug 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, URVESH1121, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@URVESH1121 URVESH1121 changed the title fix: OTHER-category at the end (#1627) fix: OTHER-category at the end Aug 25, 2023
CBID2
CBID2 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Anmol-Baranwal
Anmol-Baranwal reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@CBID2
Copy link
Collaborator

CBID2 commented Aug 25, 2023

🚀 Looks good to me.

Did you press the Agree option @Anmol-Baranwal? It won't let me merge the PR.

Anmol-Baranwal
Anmol-Baranwal approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 My bad.

Looks good to me. Ready to merge.

My network is glitchy.

@CBID2 CBID2 merged commit 7fd9d1a into rupali-codes:main Aug 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

Assignees

@URVESH1121 URVESH1121

Labels
bug Something isn't working goal: new-category Addition of new categories related contributions quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] place OTHER category at the end in the sidebar
3 participants
@URVESH1121 @CBID2 @Anmol-Baranwal