Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description for programming languages: #1621

Merged

Conversation

the-shivam-gupta
Copy link
Contributor

The tooltip description for the following languages
1.Cpp
2.Kotlin
3.Rust
4.Dart
5.Java
has been added.

Fixes Issue

#1617

Changes proposed

Screenshots

image

Note to reviewers

The tooltip description for the following languages
    1.Cpp
    2.Kotlin
    3.Rust
    4.Dart
    5.Java
has been added.
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 1:31pm

@github-actions github-actions bot added the quick-fix Shouldn't take much time to finish label Aug 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the-shivam-gupta, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

@CBID2
Please review this.

k-deepak04
k-deepak04 previously approved these changes Aug 24, 2023
rupali-codes
rupali-codes previously approved these changes Aug 24, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

components/TopBar/CategoryDescriptions.ts Outdated Show resolved Hide resolved
@CBID2 CBID2 dismissed stale reviews from rupali-codes and k-deepak04 via 12cdaa3 August 25, 2023 13:30
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Aug 25, 2023

@CBID2

Please review this.

Going to need your approval @Anmol-Baranwal

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal merged commit 3246291 into rupali-codes:main Aug 25, 2023
6 checks passed
@the-shivam-gupta the-shivam-gupta deleted the missing-description branch August 27, 2023 17:06
@CBID2 CBID2 linked an issue Sep 17, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Tooltip description are missing for some languages.
5 participants