Fix SSG not generating the actual page content on initial load

[abhijithmuthyala]

Fixes Issue

Closes #1477

Changes proposed

• Generate the actual page content on initial load (/ and /[subcategory] routes), not just the Spinner />.
• Fallback to 404 for the /[subcategoryThatsNotInTheDatabase] routes.

Screenshots

Before

empty-prerender.-.Made.with.Clipchamp.mp4

After

ssg.mp4

Note to reviewers

Currently, the route for a subcategory that isn't in the database (/cat for example) behaves almost as if a search query with that name is submitted (/search?query=cat), which certainly is a bug. In this PR I had to choose a fallback, and I went with a 404 page (fallback: false). If it's preferred to retain the current behaviour, fallback: 'blocking' can be temporarily used.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
linkshub	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 26, 2023 4:30am

[github-actions]

Thank you, abhijithmuthyala, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

[Anmol-Baranwal]

@abhijithmuthyala
Post a video on what is changed. It will help us reviewing this quickly.

[CBID2]

LGTM

[Anmol-Baranwal]

@CBID2
I don't think level is needed anymore, since it was specific for GSSoC'23. Feel free to add it, if you think otherwise.

[CBID2]

@CBID2

I don't think level is needed anymore, since it was specific for GSSoC'23. Feel free to add it, if you think otherwise.

Let's see what @rupali-codes thinks.

[rupali-codes]

@CBID2 I don't think level is needed anymore, since it was specific for GSSoC'23. Feel free to add it, if you think otherwise.
it would be better if we can rename the labels,

[CBID2]

@CBID2 I don't think level is needed anymore, since it was specific for GSSoC'23. Feel free to add it, if you think otherwise.

it would be better if we can rename the labels,

So...do you agree or not @rupali-codes?

[rupali-codes]

@CBID2 I don't think level is needed anymore, since it was specific for GSSoC'23. Feel free to add it, if you think otherwise.

it would be better if we can rename the labels,

So...do you agree or not @rupali-codes?

i do..remove the labels for now

[abhijithmuthyala]

@abhijithmuthyala Post a video on what is changed. It will help us reviewing this quickly.

Video posted in the linked issue is the bug and the one in this PR is the fix. I thought it would be unnecessary to duplicate the bug video both in the issue and in the PR. If it is preferred to have it in both the places, I'll keep that in mind for future contributions.

[Anmol-Baranwal]

@abhijithmuthyala Post a video on what is changed. It will help us reviewing this quickly.

Video posted in the linked issue is the bug and the one in this PR is the fix. I thought it would be unnecessary to duplicate the bug video both in the issue and in the PR. If it is preferred to have it in both the places, I'll keep that in mind for future contributions.

No, you shouldn't add a duplicate video. You can simply reference it.

I asked what the change was. It would be helpful to see it visually in the video.

[abhijithmuthyala]

I asked what the change was. It would be helpful to see it visually in the video.

Hmm, I already posted the bug video in the issue and the fix video in the PR though? Anyways, if it is helpful to repeat the bug video here, sure. I updated the PR description, please check.

[Anmol-Baranwal]

I asked what the change was. It would be helpful to see it visually in the video.

Hmm, I already posted the bug video in the issue and the fix video in the PR though? Anyways, if it is helpful to repeat the bug video here, sure. I updated the PR description, please check.

I thought the PR one was the bug video. My bad😅 That's why I was suggesting that you post a video solution, but without repeating the bug video. No worries. I will check it out soon.

[CBID2]

LGTM

[Anmol-Baranwal]

🚀 Looks good to me.

It will be better if you can also describe the approach of the code from next time. Because reviewing it without that would take a lot of time.

@rupali-codes
Please review this.