Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joseph smith added #1556

Merged
merged 3 commits into from
Aug 13, 2023
Merged

joseph smith added #1556

merged 3 commits into from
Aug 13, 2023

Conversation

S-ishita
Copy link
Contributor

Fixes Issue

closes #1502

Changes proposed

Screenshots

Screenshot from 2023-08-10 18-24-04

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 4:43am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, S-ishita, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@k-deepak04
Copy link
Contributor

@S-ishita resolve the conflicts

database/youtube/web-development.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested a review from k-deepak04 August 11, 2023 04:43
@CBID2 CBID2 added quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) goal: new-link Addition of new links related contributions labels Aug 11, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@rupali-codes rupali-codes merged commit f0232ec into rupali-codes:main Aug 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] joseph smith webdev
4 participants