Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/Link template updated #1550

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Issue/Link template updated #1550

merged 3 commits into from
Aug 11, 2023

Conversation

k-deepak04
Copy link
Contributor

@k-deepak04 k-deepak04 commented Aug 10, 2023

Fixes Issue

Closes #1549

Changes proposed

verified the deployment and categoried section then updated the issue/add_link template to match with that categories

Screenshots

image

image

image

Note to reviewers

reviewed and verified all the source data from the deployment to codebase and added the remaining category and make sure things are proper everywhere

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 11:41am

@github-actions github-actions bot added quick-fix Shouldn't take much time to finish goal: new-link Addition of new links related contributions labels Aug 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, k-deepak04, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@k-deepak04
Copy link
Contributor Author

@rupali-codes @CBID2 please review and merge

CBID2
CBID2 previously approved these changes Aug 10, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 added gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) goal: new-category Addition of new categories related contributions bug Something isn't working and removed goal: new-link Addition of new links related contributions goal: new-category Addition of new categories related contributions labels Aug 10, 2023
This reverts commit 0022b9a.
@k-deepak04
Copy link
Contributor Author

LGTM

can you please review again.....by mistakelny i have added commits in this and had to revert them back
so sorry for the inconvenience

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

LGTM

can you please review again.....by mistakelny i have added commits in this and had to revert them back

so sorry for the inconvenience

Done. Also mention the changes you made in the "Changes Proposed" section of the issue form.

@rupali-codes rupali-codes merged commit 79de462 into main Aug 11, 2023
6 checks passed
@rupali-codes rupali-codes deleted the issue_temp branch August 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Competitive programming is not in the issue template
3 participants