Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsa resources #1535

Merged
merged 5 commits into from
Aug 10, 2023
Merged

dsa resources #1535

merged 5 commits into from
Aug 10, 2023

Conversation

karthiknadar1204
Copy link
Contributor

@karthiknadar1204 karthiknadar1204 commented Aug 9, 2023 •
edited by CBID2
Loading

Fixes

Closes #1375

Changes proposed

Add dsa resources in javascript

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 11:32am

github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, karthiknadar1204, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2
CBID2 previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested a review from k-deepak04 August 10, 2023 01:27
@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge labels Aug 10, 2023
rupali-codes
rupali-codes previously approved these changes Aug 10, 2023
View reviewed changes
@rupali-codes
Copy link
Owner

please don't over-do anything. Make the changes specific to your issue. If you wanna make any other changes please raise a different issue

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Fix the conflicts @k-deepak04

@rupali-codes
Copy link
Owner

rupali-codes commented Aug 10, 2023 •
edited by CBID2
Loading

Fix the conflicts @karthiknadar1204

it should be @karthiknadar1204 no?

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Fix the conflicts @karthiknadar1204

it should be @karthiknadar1204 no?

Yeah thanks for clarifying @rupali-codes

@karthiknadar1204
Copy link
Contributor Author

Done @rupali-codes @CBID2

@k-deepak04
Copy link
Contributor

k-deepak04 commented Aug 10, 2023 •
edited by CBID2
Loading

Fix the conflicts @karthiknadar1204

🥲

CBID2
CBID2 requested changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the description for Coding Ninjas twice

database/youtube/data-structures.json Outdated Show resolved Hide resolved
@CBID2 CBID2 removed the status: ready-to-merge Approved & its ready-to-merge label Aug 10, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Fix the conflicts @karthiknadar1204

🥲

Sorry @k-deepak04

@karthiknadar1204
Copy link
Contributor Author

I added resources for javascript by code step by step @CBID2

@karthiknadar1204
Copy link
Contributor Author

not the one with python

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

not the one with python

Oh ok

@k-deepak04
Copy link
Contributor

Fix the conflicts @karthiknadar1204

🥲

Sorry @k-deepak04

no worries
chill 💃

CBID2
CBID2 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Now you can review @k-deepak04

k-deepak04
k-deepak04 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@k-deepak04 k-deepak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@k-deepak04 k-deepak04 merged commit 4f6ab99 into rupali-codes:main Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@k-deepak04 k-deepak04 k-deepak04 approved these changes

@rupali-codes rupali-codes rupali-codes left review comments

Assignees

@karthiknadar1204 karthiknadar1204

Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] Add resources for data structures and algorithms
4 participants
@karthiknadar1204 @rupali-codes @CBID2 @k-deepak04