Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make search bar sticky and adjust scrollable area #1431

Merged

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

Closes #1418

Changes proposed

Why search bar should be sticky.

  • Users can keep their search query visible while exploring different categories. This helps them remember their search context and makes it easy to refine or modify their search without losing sight of the results.
  • With a sticky search bar, users can focus on interacting with the search input without distractions, as it remains in a fixed position regardless of their scrolling behavior.

Screenshots

Sticky search bar
image

Note to reviewers

  • I initially attempted different styling approaches but later changed my approach after trying various options, as this one appeared to be the most sophisticated and easy to understand.

@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 10:51am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@rupali-codes
Copy link
Owner

@Anmol-Baranwal can we reduce the space between this two?

image

@rupali-codes rupali-codes added quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level2 Modifying an existing feature labels Jul 31, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

Anmol-Baranwal commented Aug 1, 2023

@Anmol-Baranwal can we reduce the space between this two?

image

Done.

image

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 2193bff into rupali-codes:main Aug 7, 2023
1 check passed
@Anmol-Baranwal Anmol-Baranwal deleted the hack_searchbar_nonscrollable branch August 7, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code participants level2 Modifying an existing feature quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] remove search bar from scrollable area
3 participants