Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resourcs for react #1364

Closed

Conversation

karthiknadar1204
Copy link
Contributor

Fixes Issue #1239

Changes proposed

Added resources for react js.

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Jul 25, 2023 3:43am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, karthiknadar1204, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a proofreading suggestion. Other than that, you're off to a great start! :)

database/frontend/react.json Outdated Show resolved Hide resolved
@CBID2 CBID2 added goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish labels Jul 22, 2023
@CBID2 CBID2 linked an issue Jul 22, 2023 that may be closed by this pull request
4 tasks
@karthiknadar1204
Copy link
Contributor Author

will correct it and push the changes again thank you @CBID2

@karthiknadar1204
Copy link
Contributor Author

@CBID2 Have pushed the changes again, please check now

Copy link
Contributor Author

@karthiknadar1204 karthiknadar1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CBID2
CBID2 previously approved these changes Jul 25, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @karthiknadar1204! :) You just need one more approved review before merging occurs! :)

@CBID2 CBID2 requested a review from k-deepak04 July 25, 2023 00:20
k-deepak04
k-deepak04 previously approved these changes Jul 25, 2023
@k-deepak04
Copy link
Contributor

@karthiknadar1204 please resolve the conflicts

@karthiknadar1204
Copy link
Contributor Author

Done @k-deepak04

@k-deepak04
Copy link
Contributor

k-deepak04 commented Jul 26, 2023

@karthiknadar1204 deployment is failing plz check.
@rupali-codes plz give him the error code snippet.

@karthiknadar1204
Copy link
Contributor Author

should i open another pr?

@CBID2
Copy link
Collaborator

CBID2 commented Jul 27, 2023

This PR is closed because #1399 solved it.

@CBID2 CBID2 closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Add reesource for react js
3 participants