Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add pagination buttons at the top-right corner #2071

Closed
2 of 4 tasks
rupali-codes opened this issue Oct 22, 2023 · 14 comments
Closed
2 of 4 tasks

[Feature] Add pagination buttons at the top-right corner #2071

rupali-codes opened this issue Oct 22, 2023 · 14 comments
Assignees
@Rohxn16
Labels
goal: new-feature New feature or request good first issue Good for newcomers priority: medium Modifying an existing feature 🚀 ready

Comments

@rupali-codes
Copy link
Owner

Description

Adding pagination buttons at the top-right corner would lead to a great user experience, as the user won't have to scroll down to bottom to navigate through different pages.

Add the buttons in top-right corner below the social media icons, and do NOT remove the pagination buttons from the bottom.

Screenshots

IMG_20231022_180024

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
  • I am participating in Hacktoberfest 2023
@rupali-codes rupali-codes added goal: new-feature New feature or request good first issue Good for newcomers up for grabs this issue open for the taking priority: medium Modifying an existing feature hacktoberfest hacktoberfest2023 labels Oct 22, 2023
@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Repository owner unlocked this conversation Oct 22, 2023
@Rohxn16
Copy link

Rohxn16 commented Oct 22, 2023

/attempt #2071
I will try fixing this.

@Anmol-Baranwal
Copy link
Collaborator

@Rohxn16
If you're sure of handling this, then let me know. I will assign you the issue then you can proceed to work on this.

@Rohxn16
Copy link

Rohxn16 commented Oct 23, 2023

@Anmol-Baranwal please do

@CBID2 CBID2 removed the up for grabs this issue open for the taking label Oct 23, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Oct 23, 2023

@Anmol-Baranwal please do

You're assigned @Rohxn16

@rupali-codes
Copy link
Owner Author

@Rohxn16 are you working on this issue?

@Rohxn16
Copy link

Rohxn16 commented Nov 6, 2023

@rupali-codes actually not, u can assign it someone else, ive been pretty occupied lately.

@Raj100679
Copy link
Contributor

@rupali-codes , Can you assign this issue to me?
I will try working on it

@rupali-codes
Copy link
Owner Author

@rupali-codes , Can you assign this issue to me?
I will try working on it

Yes, sure

@Raj100679
Copy link
Contributor

@rupali-codes I have added the feature on laptop or desktop view but what should it look like when its viewed in smaller screen

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes I have added the feature on laptop or desktop view but what should it look like when its viewed in smaller screen

Please raise a PR. We will check it and let you know what should be done for various screen sizes.

@Raj100679 Raj100679 mentioned this issue Nov 8, 2023
Closed
@github-actions github-actions bot closed this as completed Dec 9, 2023
@Anmol-Baranwal Anmol-Baranwal reopened this Dec 9, 2023
@Raj100679
Copy link
Contributor

@Anmol-Baranwal what changes do we need ?

@Anmol-Baranwal
Copy link
Collaborator

@Anmol-Baranwal what changes do we need ?

The issue was stale, so it automatically closed. The changes are requested by @aftabrehan in the #2181
Ask him.

@CBID2 CBID2 removed the hacktoberfest hacktoberfest2023 label Dec 17, 2023
@nayansinghal23
Copy link

nayansinghal23 commented Jan 7, 2024 •
edited
Loading

@rupali-codes and @CBID2, I have worked on this issue and created a PR. I request you to review it and provide me with the feedback please.

@Anmol-Baranwal Anmol-Baranwal mentioned this issue Jan 17, 2024
Merged
rupali-codes pushed a commit that referenced this issue Jan 23, 2024
@Raj100679
#2071-Side pagination (#2236)
229077d 
* Done the following changes

Signed-off-by: Raj <[email protected]>

* Minor changes in subcategory page

Signed-off-by: Raj <[email protected]>

* Fixed Errors

---------

Signed-off-by: Raj <[email protected]>
Co-authored-by: Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rohxn16 Rohxn16

Labels
goal: new-feature New feature or request good first issue Good for newcomers priority: medium Modifying an existing feature 🚀 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added Side Pagination button #2071 Raj100679/LinksHub
6 participants
@Anmol-Baranwal @rupali-codes @Raj100679 @nayansinghal23 @CBID2 @Rohxn16