Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navbar redesign #130

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: navbar redesign #130

wants to merge 6 commits into from

Conversation

KAJdev
Copy link

@KAJdev KAJdev commented Aug 9, 2024

No description provided.

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Aug 27, 2024 3:54pm

@maglietti
Copy link

image

@frankmyles, the RunPod logo lockup does not match the approved brand guideline. The spacing between the icon and the text is too large, and the "RunPod" text is not sized correctly to the icon.

image

I also noticed that the contrast for the text input box is very low now in dark mode. It is acceptable in light mode, but should still be checked.

image

Additionally, the control characters in the text box are no longer aligned.

Before:
image

After:
image

Copy link

@maglietti maglietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Resolve the Logo Lockup
  • Adjust the contrast of the Search text box
  • Align the command keys glyphs inside the search text box

Copy link

@maglietti maglietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks @KAJdev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants