Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tilemanmode #6322

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update tilemanmode #6322

wants to merge 2 commits into from

Conversation

sram1337
Copy link
Contributor

ConorLeckey/Tileman-Mode#48

The plugin was currently using a few terminally deprecated APIs that had to be updated for the plugin hub build to succeed. I also fixed some of the non-terminally deprecated APIs and removed some unused co

ConorLeckey/Tileman-Mode#47

Skipped tiles when running instead of walking are currently incorrectly interpolated when doing L-shaped movement around an object. This fix allows the filled in tiles to be correct for all cardinal directions (both negative and positive delta x- and y-movement).


ConorLeckey/Tileman-Mode#48

The plugin was currently using a few terminally deprecated APIs that had to be updated for the plugin hub build to succeed. I also fixed some of the non-terminally deprecated APIs and removed some unused co

ConorLeckey/Tileman-Mode#47

> Skipped tiles when running instead of walking are currently incorrectly interpolated when doing L-shaped movement around an object. This fix allows the filled in tiles to be correct for all cardinal directions (both negative and positive delta x- and y-movement).
@runelite-github-app
Copy link

runelite-github-app bot commented Jul 18, 2024

Includes changes by non-author

tilemanmode: 132ec336de89ffd80f04e85c805b3c6ecdd4d9eb...7cc83e591204044bfb9260a3733c52817ebb727d

@YvesW
Copy link
Member

YvesW commented Jul 18, 2024

#6298 (comment) Also, that previous PR hasn't even been merged yet.

@Alexsuperfly
Copy link
Contributor

it looks like you have merge privileges to the tilemanmode repo so just add your name to the authors field so the bot removes the non author tag

Point to commit with updated authors
@Alexsuperfly
Copy link
Contributor

not in the plugin itself but the manifest here, for example the authors field for 117HD

@MESLewis MESLewis marked this pull request as draft October 3, 2024 15:53
@MESLewis
Copy link
Member

MESLewis commented Oct 3, 2024

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-author plugin change plugin change waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants