chore: Remove some references to pkg/errors #5270
Open
+34
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
the
refactoring
Signed-off-by: Luke Massa <[email protected]>
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
remove_pkg_error_references
branch
from
829fce8 to
554b97d
Compare
Signed-off-by: Luke Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Remove references to
pkg/errorsfrom server/core/config packages.why
Per #5269 we should be removing this dependency. I picked this package first because it has a somewhat complicated use of the pkg/errors and I wanted to make sure it worked as expected.
tests
Running unit tests
references