Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.get_nodes now accepts include_values param to return embeddings #17635

Merged

Conversation

LHFO94
Copy link
Contributor

@LHFO94 LHFO94 commented Jan 26, 2025

Description

PineconeVectorStore.get_nodes() was not parsing the embedding values into a BaseNode. I added a bool, if True the embeddings will be parsed into a BaseNode. If False the pinecone_index.query will also not retrieve the embeddings values.

Fixes (#17627)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

A Bit of both a Bug fix and New Feature, will put this under Bug fix as it aligns with issue tag.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 26, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 26, 2025 22:02
@logan-markewich logan-markewich merged commit c727d39 into run-llama:main Jan 27, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants